Giter VIP home page Giter VIP logo

Comments (4)

ashtonlclark avatar ashtonlclark commented on June 3, 2024 6

Thanks @pradeepshekhawat.

Dokan team, can you fix this in the Dokan Pro plugin properly?

from dokan.

pradeepshekhawat avatar pradeepshekhawat commented on June 3, 2024

@ashtonlclark sir,

for the fix is to use the return statement (return $err) in maybe_delete_coupon function

Update to like this

public function maybe_delete_coupon( $err, $err_code, $coupon ) {
    if ( Helper::is_vendor_order_discount_coupon( $coupon ) || Helper::is_vendor_product_quantity_discount_coupon( $coupon ) ) {
        $coupon->delete( true );
    }
    return $err;
}

Instead of this

public function maybe_delete_coupon( $err, $err_code, $coupon ) {
    if ( Helper::is_vendor_order_discount_coupon( $coupon ) || Helper::is_vendor_product_quantity_discount_coupon( $coupon ) ) {
        $coupon->delete( true );
    }
}

from dokan.

Aunshon avatar Aunshon commented on June 3, 2024

Thanks @pradeepshekhawat.

Dokan team, can you fix this in the Dokan Pro plugin properly?

Thanks @ashtonlclark
We have already given the fix and created a pull request, you will find the release soon.

from dokan.

ashtonlclark avatar ashtonlclark commented on June 3, 2024

Thank you. @Aunshon. Do you think this fix will be included in the next Dokan Pro release?

from dokan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.