script_list.splice.call(script_list,splice_args); about labjs HOT 9 CLOSED

I think you're right, the splice call is needlessly verbose as written. it should just be script_list.splice(splice_args).

I'm not sure I understand your second question. $LAB.script("test1.php", ["test2.php", "test3.php"]) should in fact load all 3 scripts. Are you seeing it not do so?

from labjs.

$LAB.script(['test1.php',['test2.php','test3.php']]);

it just has one parameter ['test1.php',['test2.php','test3.php']] ,not two parameters "test1.php" and ["test2.php", "test3.php"]

from labjs.

I'm sorry, I still don't understand your question. In your example, is it loading all 3 scripts or not?

from labjs.

... I try it again , that may be my mistake

from labjs.

I push the example to internet .http://dexbol.sinaapp.com/labjs/

from labjs.

OK, I see and can reproduce the problem... very strange. But thank you for the bug report. I'll get on fixing it.

from labjs.

OK, I figured out what the bug was, and have fixed it (will come out in 2.0.2 when I get that release out, asap). Those few lines now read (including comments to explain what the heck I was doing!):

if (is_array(script_obj)) {
   // set up an array of arguments to pass to splice()
   splice_args = [].slice.call(script_obj); // first include the actual array elements we want to splice in
   splice_args.unshift(j,1); // next, put the `index` and `howMany` parameters onto the beginning of the splice-arguments array
   script_list.splice.apply(script_list,splice_args); // use the splice-arguments array as arguments for splice()
   j--; // adjust `j` to account for the loop's subsequent `j++`, so that the next loop iteration uses the same `j` index value
   continue;
}

Thanks again for helping find this bug!

from labjs.

OK，thanks for your code and explain too.

from labjs.

fixed in v2.0.2

from labjs.