Better diagnostics and/or default for MELI_MAX_ORGS about meli HOT 3 OPEN

You're absolutely right, the current frontend error management lacks the ability to extract error messages from backend errors. The reason is we're doing toast.error(Could not create org: ${err}); which converts the error object to a string via a JS string template, only extracting the Error.message (native behavior of error.toString()) instead of actually extracting the message from the backend response. These errors are actually axios errors and the backend message can be retrieved from error.response.data.message. A safe option would be to do it this way: toast.error(Could not create org: ${error.response?.data?.message || error.message});. But I would extract this to a function to generalize the error handling behavior across the app.

As Meli is meant to be deployed on your VPS, 1 is a sane default, as we expect that you most likely not want your users to create more organizations.

from meli.

@gemapin It appears somebody already did "extract this to a function". It is called extractExrrorMessage and it can be found in ui/src/utils/extract-exrror-message. I thought the name of the file was a typo until I saw it matches the name of the function. Is this a typo? I don't see why the extra x is in there. But in any case, this appears to be the function to use to extract an error message generically. I can submit a pull request with all the toast calls invoking this function. But do you want me to rename this function while I'm at it?!?

from meli.

Oh yes that's right, I think I created this function and left that aside for some reason. You can definitely reuse that and make the changes you suggested. You can also rename the function, it's a typo 😅 . I'd change the function however, because I realize that the response.data.message is potentially null, so to be safe here's what I'd do:

import { AxiosError } from 'axios';

export function extractErrorMessage(err: any) {
  let message: string;
  if (err.isAxiosError) {
    message = (err as AxiosError).response?.data?.message;
  }
  return message || err.message;
}

from meli.