Giter VIP home page Giter VIP logo

Comments (10)

yanokwa avatar yanokwa commented on July 29, 2024 1

So the options are:

  1. Change dialog option to Close/Quit
  2. Get rid of the popup, but lock the user to settings and add some language to settings screen to say that it's required.

I don't like the popup, but I bias towards Close/Quit as a solution because we'll probably be changing Briefcase's UX anyway and Close/Quit is a straightforward fix. Paging @lognaturel and @nribeka for feedback.

from briefcase.

rclakmal avatar rclakmal commented on July 29, 2024 1

@yanokwa @nribeka @lognaturel I created a PR since it was a small change. We can further discuss this through that PR.

from briefcase.

yanokwa avatar yanokwa commented on July 29, 2024

@rclakmal I'm not sure what to do here. Instead of removing the Cancel button, maybe we should quit the application? Or take the user to the Settings tab (and they can't leave that tab)?

Any other ideas @shivam-tripathi @icemc @nribeka?

from briefcase.

rclakmal avatar rclakmal commented on July 29, 2024

@yanokwa Well technically, user shouldn't be able to cancel the selection of a folder since it's a mandatory requirement.

I think your idea of directing to Settings tab is nice. But then, why wouldn't we just redirect the user to Settings page and make them do this setting on the first launch instead of this popup dialog ?

from briefcase.

yanokwa avatar yanokwa commented on July 29, 2024

Redirecting to Settings seems like it'll be more complicated. You'd then have to prevent them from doing anything until they select a folder.

Another option is instead of Cancel, we replace that with Quit.

from briefcase.

rclakmal avatar rclakmal commented on July 29, 2024

My point was not adding redirection. Rather, get rid of the popup and start the main window with the focus on Settings view and not letting user to browse other view until a folder path is set.

However, Changing the button to a "Close/Quit" would be an easy option.

from briefcase.

rclakmal avatar rclakmal commented on July 29, 2024

@yanokwa Shall I move forward with "Close" option and submit a PR?

from briefcase.

shivam-tripathi avatar shivam-tripathi commented on July 29, 2024

For a quick fix, in my opinion, we can change the "Cancel" button with a "Quit" button.
Settings tab can contain (in future) a lot of irrelevant requirements for a welcome page (presently it has only location option), for example giving options related to form falsification or addition of other features (in future) which may require some form of user settings. So it would be a design decision to whether make a "Welcome page" which shows all ODK storage locations in the system (which will be an empty list if no location has been registered previously) with an option to add a new one, or go with a pop up or use the settings tab.
Arguments in favor of a welcome screen revolves around the following:

  • It would only ask for information needed when the application is launched.
  • Launching briefcase again doesn't necessary mean that I want to use the same location folder. Upon each launch, user can select the location.
  • To avoid repetition of a welcome screen, we can give an option to "Remember location settings" with a message "You can always change your location settings in the 'Settings' tab". Next time, automatically load the forms from the previous location.
    Opinions?

from briefcase.

rclakmal avatar rclakmal commented on July 29, 2024

Launching briefcase again doesn't necessary mean that I want to use the same location folder. Upon each launch, user can select the location.

Idea of multiple storage locations could make things little complex from UI perspective and as far as I see it doesn't add any extra value from user's perspective.

from briefcase.

yanokwa avatar yanokwa commented on July 29, 2024

Thanks for all the ✨great✨ feedback.

I think we'll go with the Cancel/Quit option for now. I'll review the PR shortly. 👨🏿‍💻

from briefcase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.