Giter VIP home page Giter VIP logo

Comments (6)

marandaneto avatar marandaneto commented on August 18, 2024 2

cc @untitaker @rhcarvalho @bruno-garcia

from develop.

untitaker avatar untitaker commented on August 18, 2024

sgtm

from develop.

bruno-garcia avatar bruno-garcia commented on August 18, 2024

At first I thought it was related to https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md but turns out it's just our on op for Spans.

Makes sense to align like you suggested. That means we're changing python though @ahmedetefy or @rhcarvalho ? To have http.server and http.client ? Possibly other SDKs too.

from develop.

rhcarvalho avatar rhcarvalho commented on August 18, 2024

Yes, AFAICT the names were based on old versions of the semantic conventions (same for span statuses).

I'm good with http.server and http.client, don't see a problem with changing this for all SDKs. AFAIK the Sentry UI does not rely on specific names.

from develop.

ahmedetefy avatar ahmedetefy commented on August 18, 2024

Sounds good! Opened up a ticket for it https://app.asana.com/0/1159797622087522/1200117075062458

from develop.

marandaneto avatar marandaneto commented on August 18, 2024

https://develop.sentry.dev/sdk/performance/span-operations/

from develop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.