Giter VIP home page Giter VIP logo

Comments (4)

adinauer avatar adinauer commented on June 3, 2024

Thanks for opening this issue @Akil17 we currently don't know of any replacement library for p6spy. We also have #3179

from sentry-java.

adinauer avatar adinauer commented on June 3, 2024

We just discussed and what you could try is opening a PR in p6spy repo to forward .toString() in PreparedStatementWrapper to the delegate PreparedStatement. Not sure if they still merge PR's or do releases tho.

After reading your Stackoverflow post, maybe you could modify the query before it's converted to a PreparedStatement. Maybe your SQL library offers something for pagination.

For future maybe https://github.com/r2dbc/r2dbc-proxy could be used but we need to investigate how many dependencies this drags in, whether it actually works for us and whether we can have some hook to extract query etc.

from sentry-java.

Akil17 avatar Akil17 commented on June 3, 2024

@adinauer I appreciate your response.

I can make the change, but I am not certain if the PR will ever get merged.

Regarding the second point, I can't modify the query before it's converted to a PreparedStatement as it sets values in the query. Additionally, my use-case is not limited to pagination; there are other analytics-related use-cases as well where we do need an actual query.

I would suggest Sentry can maintain its own p6spy branch if possible and by default add that as a dependency in the BE SDKs.

from sentry-java.

adinauer avatar adinauer commented on June 3, 2024

I would suggest Sentry can maintain its own p6spy branch if possible and by default add that as a dependency in the BE SDKs.

If more problems with p6spy come up, we can consider this. At the moment there are no plans to do so.

Maybe the quickes way to solve your problem is to fork p6spy, make your changes and use your own version.

from sentry-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.