Comments (11)
I don't think it's really great behavior. If you're sending a lot of data that is hanging user requests you need to ask why that data is being sent. If they're errors then a small delay in the response is acceptable and at least guarantees errors are reported when your workers aren't functioning.
With that said, we have async support in the php SDK, and it just needs a bit of polish to be enabled by default.
from sentry-laravel.
to add.. on other hand. if there would be queue support. we would not need 3rd party implementations for laravel. less efforts, less forks... everyone wins!
from sentry-laravel.
Maybe @dcramer could enlighten us if he thinks this would be in the scope of the package and maybe someone could PR this.
from sentry-laravel.
@gregrobson, this is not what the issue is about... this issues is asking if events are sent using the queue (so the sending of issues is non-blocking), which for the record is not the case.
Also Exceptions
thrown in queues are catched by default if you use the integration as described in the README by adding it to your error handler class.
Adding it to the failed method of you queue job can even result in double reporting (not sure if the error handler is skipped if you implement the failed method).
from sentry-laravel.
If you want queues you will have to use https://github.com/twineis/raven-php.
from sentry-laravel.
This does not integrate with the queues it sends errors as soon as it recieves them in the same request.
Why would you want it to use the queue if I may ask?
from sentry-laravel.
So the user doesn't have to wait for application to send error/warning to sentry but is instead loaded 'instantly'.
from sentry-laravel.
Okay I understand. I assume then your application sends more things to Sentry then breaking exceptions (as in 500 errors). Might be simpeler to just implement your own queue job to do this.
I personally rather have the error sent instantly in case the queues are also broken.
from sentry-laravel.
evryone has it's own preferences I think. I prefer not to 'delay' the user.. because usually exception in the queue can be handled later.
I just asked if this package supported this.. well no then no :)
from sentry-laravel.
For anyone else looking at this old thread - you can use the failed(\Exception $exception)
handler in Laravel to force errors to be sent across.
https://stackoverflow.com/questions/49509750/send-error-report-to-sentry-within-laravel-queue
https://laravel.com/docs/5.6/queues#dealing-with-failed-jobs
from sentry-laravel.
@stayallive Ah, my fault, didn't read it closely enough.
Odd - My errors are only being reported when I log them using the global Queue::failing()
handler (and they only log once). I see you recently released v0.9.0 with channel support: I'll upgrade and double check the behaviour - if it's still causing issues I'll raise an separate ticket.
Thanks for the quick response! 👍
from sentry-laravel.
Related Issues (20)
- Report missing translations
- Unable to set up sentry sdk debug logger option in Laravel 7 HOT 11
- Data not being send to Sentry HOT 2
- [Cron Monitoring] Whether to consider adding a switch configuration option for Cron monitoring? HOT 2
- Configure Cron Monitoring based on environment HOT 1
- Idle timeout reached HOT 4
- Scheduled task tracing
- Disabling SSL Verify Peer HOT 2
- Add support for Laravel 11.0's Context
- Link to Laravel v10 docs broken HOT 2
- Dependency nyholm/psr7 can be defined like require-dev HOT 1
- Does captureUnhandleException still work for Laravel 11 HOT 1
- SQLSTATE[HY000]: General error: 2006 MySQL server has gone away HOT 6
- Metrics Rate Limits HOT 1
- Wrong stack trace when using in-app middleware HOT 6
- FilesystemAdapterDecorator incompatibility in tests. HOT 2
- Performance monitoring doesn't work in artisan commands
- LighthouseIntegration does not report all the traces to Sentry HOT 4
- Call to undefined function Sentry\metrics() HOT 8
- Setting http_proxy in config/sentry.php on L10 seems to not work HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sentry-laravel.