Possible bug if transaction is not sampled? about sentry-laravel HOT 4 CLOSED

I guess this was done as an optimization? But, to keep the optimization in place, while indicating that the transaction is not sampled, maybe other tracing code could check if both $parentSpan && $parentSpan->getSampled()?

from sentry-laravel.

Yep, we're fixing this in the core, Laravel & Symfony SDKs.
We'll only keep the transaction around though, to keep memory pressure low.

from sentry-laravel.

Ok so I'm not crazy :p Not sure if core PHP SDK needs to be fixed at all, seemed like mainly an issue in Laravel thus I filed the issue here.

from sentry-laravel.

Actually, looking at core PHP SDK, the GuzzleTracingMiddleware needs some logic fixes: First of all, it looks like breadcrumb data is only set if there is a span, but I think breadcrumb data should always be set? And then, don't start span if $span exists but is not sampled.

from sentry-laravel.