Comments (4)
I guess this was done as an optimization? But, to keep the optimization in place, while indicating that the transaction is not sampled, maybe other tracing code could check if both $parentSpan && $parentSpan->getSampled()
?
from sentry-laravel.
Yep, we're fixing this in the core, Laravel & Symfony SDKs.
We'll only keep the transaction around though, to keep memory pressure low.
from sentry-laravel.
Ok so I'm not crazy :p Not sure if core PHP SDK needs to be fixed at all, seemed like mainly an issue in Laravel thus I filed the issue here.
from sentry-laravel.
Actually, looking at core PHP SDK, the GuzzleTracingMiddleware needs some logic fixes: First of all, it looks like breadcrumb data is only set if there is a span, but I think breadcrumb data should always be set? And then, don't start span if $span exists but is not sampled.
from sentry-laravel.
Related Issues (20)
- Performance monitoring doesn't work in artisan commands
- LighthouseIntegration does not report all the traces to Sentry HOT 4
- Call to undefined function Sentry\metrics() HOT 8
- Setting http_proxy in config/sentry.php on L10 seems to not work HOT 2
- before_send_check_in breaks serialization when using php artisan optimize HOT 4
- Sentry delays execution of scheduled commands when offline HOT 4
- Inform via Log in case Sentry Requests Timeout or Fail HOT 1
- Ingestion Requests affect API Response Times for Users HOT 1
- Sentry Cron Lumen not work HOT 2
- `queue.publish` span takes very long without any clear reason HOT 4
- Metrics are not flushed when used in jobs HOT 6
- Ensure out-of-memory errors are reported HOT 1
- Error: Call to undefined method Sentry\Options::getLoggerOrNullLogger() HOT 7
- Getting errors with cache tracing HOT 8
- Getting this error after switching production to roadrunner HOT 5
- Lumen without facades HOT 2
- `SENTRY_TRACES_SAMPLE_RATE` has no effect HOT 1
- Running sentry:publish a 2nd time w/ JS enabled will cause `.env` to not parse
- sentry:publish installs deprecated version of @sentry/browser and variants (v7.4.0) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sentry-laravel.