Deserialization of optional struct field with a default value about getty HOT 2 CLOSED

Ah! Looks like you found two bugs for the price of one here 😂

The first bug is the assignment of default struct values. It should be casted to the field's type as you suggested. However, instead of using @as (which actually won't work since default is a pointer, not a value), we can use @ptrCast(*const field.field_type, default_ptr).*, which is what std.json uses. default should probably also be renamed to default_ptr to make things clearer.

The second bug is in the test deserializer's deserializeOptional method. Its call to visitSome was incorrect. It was passing in the interface type (Self.@"getty.Deserializer"), not an interface value (self.deserializer()).

The lesson here is I should've written some darn tests for optional values 😅

from getty.

For more context, when the optional field has no default value specified AND the patch mentioned above is applied then I get only this part of the errors:

W:\dev\definitive_dialoguer\.gyro\getty-getty-zig-github.com-d032ff42\pkg\src\lib.zig:41:9: error: concept `getty.Deserializer` was not satisfied: missing `context` field
        @compileError("concept `" ++ concept ++ "` was not satisfied: " ++ msg);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
W:\dev\definitive_dialoguer\.gyro\getty-getty-zig-github.com-d032ff42\pkg\src\de\concepts\deserializer.zig:10:25: note: called from here
            concepts.err(concept, "missing `context` field");
            ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
W:\dev\definitive_dialoguer\.gyro\getty-getty-zig-github.com-d032ff42\pkg\src\de\interfaces\visitor.zig:137:47: note: called from here
                concepts.@"getty.Deserializer"(@TypeOf(deserializer));
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~

from getty.