Giter VIP home page Giter VIP logo

Comments (3)

gfscott avatar gfscott commented on June 15, 2024 1

Great! I just merged those lingering PRs so you should be good to go now. 👍🏻 Thanks again!

from eleventy-plugin-embed-twitter.

gfscott avatar gfscott commented on June 15, 2024

Hey @Antonio-Laguna, thanks for filing an issue! Yes, absolutely, all three ideas sound good to me. Do you want to create that PR? Do you need any help from me other than reviewing? Happy to collaborate however you'd like.

Ha, I totally forgot about my unmerged PR — after I made it I wanted to sleep on it, and then...just forgot to merge it 😅 But forgetful or not, I'm still maintaining!

from eleventy-plugin-embed-twitter.

Antonio-Laguna avatar Antonio-Laguna commented on June 15, 2024

Thanks for getting back @gfscott !

I can do that PR I just wanted to check with you to double-check you were cool with that idea before jumping into code! Should I base off #13 so tests are kept at 100%?

Thanks again!

from eleventy-plugin-embed-twitter.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.