Giter VIP home page Giter VIP logo

Comments (9)

Norlock avatar Norlock commented on August 16, 2024 1

Commit with fix: Norlock/sparticles@8bebe48 see: blend.wgsl. The commit you can go to and reproduce the bug by reverting line 15.

from naga.

teoxoy avatar teoxoy commented on August 16, 2024

This should have been fixed by #2432. You are probably missing the array layer.

from naga.

Norlock avatar Norlock commented on August 16, 2024

@teoxoy can you maybe reopen this issue? I updated wgpu to the lastest version and naga is 0.13.0 and it still produces this error? See: https://github.com/Norlock/sparticles-egui/tree/post_fx_overhaul

from naga.

teoxoy avatar teoxoy commented on August 16, 2024

The fix is not yet part of a release. Could you try wgpu trunk? Also, we are planning to do a release (which will include the fix) next week.

from naga.

Norlock avatar Norlock commented on August 16, 2024

@teoxoy I did update it with trunk by changing egui manually. If you fetch my branch and put this forked repo (https://github.com/Norlock/egui.git) next to this one. You can see it still produces the same error. Cargo tree shows it uses trunk

from naga.

Norlock avatar Norlock commented on August 16, 2024

I already fixed the issue, but the error message is wrong. For read_write textures you have to pass 2 arguments instead of 3 as the error message suggested. This was the fix:

@group(0) @binding(2) var fx_blend: texture_storage_2d<rgba8unorm, read_write>;

@fragment
fn fs_main(@builtin(position) pos: vec4<f32>) -> @location(0) vec4<f32> {
    return textureLoad(fx_blend, vec2<i32>(pos.xy));
}

from naga.

Norlock avatar Norlock commented on August 16, 2024

One more question I found with the new naga crate. Is it true I have to use same vec size in all/any comparison now?

 if all(abs(distance) < vec3<f32>(force.dead_zone)) {
    ...

before I could use:

 if all(abs(distance) < force.dead_zone) {
    ...

from naga.

teoxoy avatar teoxoy commented on August 16, 2024

That is most likely due to us updating the validation according to the spec. Double-checked and this is correct, the binary operation < requires both operands to be either scalars or vectors.

from naga.

teoxoy avatar teoxoy commented on August 16, 2024

I did update it with trunk by changing egui manually. If you fetch my branch and put this forked repo (https://github.com/Norlock/egui.git) next to this one. You can see it still produces the same error. Cargo tree shows it uses trunk

Will reopen the issue and transfer it to naga.

from naga.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.