Giter VIP home page Giter VIP logo

Comments (12)

bugeats avatar bugeats commented on May 29, 2024 59

It's not a TypeScript project. Why should it be? Can you give one reason why type hinting would enhance this project in any way? Making your catch-all error messages go away is not a reason.

from cognito-express.

cryptiklemur avatar cryptiklemur commented on May 29, 2024 33

Would love to see types added. Might be beneficial to re-open this ticket

from cognito-express.

scgarland191 avatar scgarland191 commented on May 29, 2024 23

I love this library and use it with TS, so I would dig types for it as well!

from cognito-express.

ghdna avatar ghdna commented on May 29, 2024 15

Not on the road map currently. But I'd be happy to revisit if there is more interest for it.

from cognito-express.

adamAtDemarq avatar adamAtDemarq commented on May 29, 2024 5

https://medium.com/@jtomaszewski/why-typescript-is-the-best-way-to-write-front-end-in-2019-feb855f9b164

this is why it should have typescript :)

from cognito-express.

yukari1414 avatar yukari1414 commented on May 29, 2024 5

looking forward +1

from cognito-express.

naishe avatar naishe commented on May 29, 2024 4

The PR #52 is for this issue. The PR also upgrades the library dependencies and gets rid of deprecated library that's still being used. Here is the summary

  1. Updated the project to Typescript
  2. Adds appropriate types and gets rid of inconsistencies like throwing Error vs throwing a string.
  3. Libraries like request, request-promise, and istanbul are deprecated, replaced them with fetch and nyc
  4. Expanded test coverage

I haven't tested this version extensively, but I am using a version of congnito-express with very similar changes for a almost two years without hiccup.

I am open to suggestions.

from cognito-express.

naishe avatar naishe commented on May 29, 2024

Compile time type checking maybe? It is a nice to have feature. You can get away with it with "noImplicitAny": false in tsconfig.

I think it is OK to close this issue if it is not in the roadmap. Thanks.

from cognito-express.

rodrigofeijao avatar rodrigofeijao commented on May 29, 2024

Is there any plans to get TS support to this?

from cognito-express.

iangabrielsanchez avatar iangabrielsanchez commented on May 29, 2024

looking forward to this

from cognito-express.

ioannisKatri avatar ioannisKatri commented on May 29, 2024

looking forward to this as well

from cognito-express.

abe-mused avatar abe-mused commented on May 29, 2024

looking forward to this as well

from cognito-express.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.