Question: NPM package about fir HOT 3 OPEN

Thanks for reaching out! I'm definitely open to better Node.js support.

Please let me know if you're interested in contributing.

Initially I ran the test suite with node, but I found the canvas implementations were different enough that some tests would fail in one environment and not the other.

So with limited time, I have focused on the browser environment.

from fir.

When it comes to npm, I can help out with that. It would help with a project im working on that currently just git forks the repo to get the code but long term it might be a pain to maintain upstream to fir.

For node, you don't really need it to support it to be on npm. Its not very common these days because shims are so good but many modules that only work within the browser get published to npm as bower never really took off as a browser only javascript package manager.

That being said, I have had some experience working with canvas in nodejs and i think if we use a shim like canvas and possibly a dom shim that should hopefully sort out the issues with the test suite. I can have a look at this too.

Also big thanks to you (and everyone else) who worked on this project ❤️

from fir.

Cool, thanks 👍

I'm curious which portions of the project you're interfacing with. Sometimes I'll move stuff around or rename things, so it might make sense to define a small API that's more consistent.

I tried that canvas implementation a while back, and the results were different enough to cause test failures. Though, I think that was before I implemented the ML model, so maybe the current implementation will be more resilient to pixel variations.

Send me a message on Discord if you'd like access to the test files.

from fir.