Giter VIP home page Giter VIP logo

Comments (7)

devanshj avatar devanshj commented on June 11, 2024 1

I checked again turns out it works for mostly all links but not for this specific one. It also doesn't work with the plugin, fails with the same CORS error. First I thought maybe the custom build is the problem but it works if I just write "// test" as the content so maybe the length? idk. Still I would expect it to fail via some other error not CORS.

I'm using Chrome 85.0.4183.102 with Windows 10 OS Version 1909 (Build 18363.1016) if it helps. Also thanks for the plugin tip, I knew there's a plugin (idr where I read that) but didn't know how to install it haha.

from tsplay.dev.

gillchristian avatar gillchristian commented on June 11, 2024 1

First I thought maybe the custom build is the problem but it works if I just write "// test" as the content so maybe the length? idk. Still I would expect it to fail via some other error not CORS.

Looks like is the length of the link indeed but I don't know how it is related.

I started removing code and eventually managed to create it: https://tsplay.dev/pr-63-test-1

I'll look into it.

Also thanks for the plugin tip, I knew there's a plugin (idr where I read that) but didn't know how to install it haha.

That's what is there for 😅 I guess we need to add a reference to the plugin in the page.

from tsplay.dev.

gillchristian avatar gillchristian commented on June 11, 2024 1

Might not be an actual CORS issue btw, but instead just the server replaying with the wrong headers: https://stackoverflow.com/a/60537300/4530566

Which kinda makes sense, as the OPTIONS request was successful

image

image

from tsplay.dev.

devanshj avatar devanshj commented on June 11, 2024 1

Thanks!

from tsplay.dev.

gillchristian avatar gillchristian commented on June 11, 2024

tsplay.dev does indeed redirect to tsplay-dev.now.sh, as the client and server are different applications. But CORS should be enabled.

Do you mind sharing what OS and browser was it? I was just able to create a short link from the UI (tsplay.dev/rw2Prm).

By the way, you can use the playground plugin to create short links directly there: https://www.typescriptlang.org/play?install-plugin=typescript-playground-link-shortener

Although, since it is also another domain you might also get a CORS error 🤔

from tsplay.dev.

devanshj avatar devanshj commented on June 11, 2024

I'll look into it.

Thanks!

I guess we need to add a reference to the plugin in the page.

Indeed xD

from tsplay.dev.

gillchristian avatar gillchristian commented on June 11, 2024

Should be solved now. Here's the shortened link for your example https://tsplay.dev/lWYZ3w

from tsplay.dev.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.