Comments (6)
nilsnolde
commented on May 22, 2024
1
Done in #94
from routingpy.
nilsnolde
commented on May 22, 2024
Huh.. we just had a PR fixing some other GH things, I can’t imagine that didn’t work a few weeks back. Did they release another major version and changed it?
from routingpy.
nilsnolde
commented on May 22, 2024
Jep, GH 7.0 removed the vehicle parameter: https://github.com/graphhopper/graphhopper/blob/master/CHANGELOG.md#70-14-mar-2023
from routingpy.
Serphentas
commented on May 22, 2024
Good catch. Shall I go ahead with a PR ? I'm thinking about a version parameter for the client initialization, or perhaps just the directions method, to switch between vehicle and profile.
from routingpy.
nilsnolde
commented on May 22, 2024
Shall I go ahead with a PR
that’d be great thanks!
I'm thinking about a version parameter for the client initialization
That’d be noble:) But I think we should just support whatever’s on their public API, since that’s a slippery slope. GH has twice a year major version upgrades currently, too much of a maintenance hassle to support all their deprecations to be honest.
from routingpy.
Serphentas
commented on May 22, 2024
See above, I followed your advice and simply replaced the key with no backwards support.
from routingpy.
Related Issues (20)
- Rename `test_helper` file
- MapboxOSRM: CloudFront error when 2 requests follow each other HOT 15
- Google Router distance and duration wrong for single route response HOT 1
- Valhalla PBF in-/output
- Deprecate HERE provider HOT 4
- `preference` parameter isn't read when asking for isochrones with Valhalla engine HOT 3
- Add support for map-matching HOT 1
- Documentation missing HOT 1
- Superfluous `profile` parameter HOT 2
- 3.11 is out HOT 2
- Rename `isochrones` to `reachability` HOT 2
- activate coveralls again
- Only support isochrone requests for single location
- Upper limits in input destination in Computing the Distance Matrix HOT 5
- Support Graphhopper's POST Route Endpoint HOT 9
- Remove mapbox valhalla provider HOT 1
- Use type hinting in router methods HOT 1
- Add Valhalla's expansion method to example notebooks
- Info about coverage tests in CONTRIBUTING.md
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from routingpy.