Giter VIP home page Giter VIP logo

Comments (4)

nilsnolde avatar nilsnolde commented on June 26, 2024

Ugh, yeah, that's not really nice. However, I'll pass the cup further down:
sindresorhus/github-markdown-css#76 (who also does the same with another of his projects;))

And I can also only repeat what he's saying: not planning to work on supporting that, as it's not important for us. But PR's will be welcomingly discussed and merged.

from wordpress-markdown-git.

nilsnolde avatar nilsnolde commented on June 26, 2024

BTW @noah1510 , there's a tiny fork which should do what you want:
https://github.com/hyrious/github-markdown-css

If you replace this file https://github.com/gis-ops/wordpress-markdown-git/blob/master/documents-git/css/github-markdown.css with the one from the fork, it might just work!

If you try it out, please leave feedback here. Then I can just test from my side if it doesn't screw up our case and merge.

from wordpress-markdown-git.

noah1510 avatar noah1510 commented on June 26, 2024

I just tried using the fork and everything looked exactly the same.
I guess that could be expected, since the fork only adds support for dark mode and does not change any of the old style.
So in addition to using the fork, there need to be some changes on the plugin to select the dark mode classes when wordpress uses the dark mode.

from wordpress-markdown-git.

nilsnolde avatar nilsnolde commented on June 26, 2024

This got merged finally upstream: sindresorhus/github-markdown-css#76

I tried to find out how WP toggles dark mode, but it seems to be theme-specific. I couldn’t find any sort of API in WP that toggles it. We can’t solve theme-specific stuff here I’m afraid..

from wordpress-markdown-git.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.