Comments (6)
Using the pre-commit hook doesn't reproduce the issue in 18f2591 that disabled the button, but I can confirm seeing the progress bar in the current version (which is 4fe1790).
from git-cola.
We can reopen if you see this again. cheers
from git-cola.
Thanks for the heads-up. We have a somewhat-new behavior where we replace the "Commit" button with a progress bar "button" that takes its place. It's supposed to reset itself back to a normal commit button as soon as the git commit
action completes.
When this happens are you seeing the button disable itself completely and it never returns? Another thing we do (but this is long-standing) is that the "Commit" button disables itself when the "Subject" field has not yet been filled in. I can see in the screenshot that you do have something in that field, so it should be enabled.
My immediate thought is that we shouldn't hide the "Commit" button but rather display a temporary progress bar in the dock titlebar area instead.
from git-cola.
When this happens are you seeing the button disable itself completely and it never returns?
Yes.
My immediate thought is that we shouldn't hide the "Commit" button but rather display a temporary progress bar in the dock titlebar area instead.
Please note that I'm unable to reproduce the bug (it's only happened 2 to 3 times across a week or two).
from git-cola.
I pushed in a change that makes it so that we stop hiding the Commit button. This should help in case there's some subtle behavior around hiding widgets that's causing it to lose its icon and text.
Let me know if you're able to reproduce this with the latest from git. Thanks for reporting this before I tagged the next release. I'll let this cook for a another week or so before I do that. cheers!
from git-cola.
In case it helps reproduce this issue, you can use a git pre-commit hook to slow down git commit
. Create an executable script at .git/hooks/pre-commit
with this content:
#!/bin/sh
echo pre-commit hook
sleep 3
That'll make git commit
take 3 seconds to run, which is long enough to get the progress bar to appear.
from git-cola.
Related Issues (20)
- Mac Cmd+M (minimize window) is ignored by git-cola and has different action HOT 1
- Commit message input box pre-filled at startup HOT 2
- Ignoring a file locally fails if within a worktree HOT 2
- Programmatically change the UI theme? HOT 1
- please look into fixing the "flashbang" effect when the main window spawns (windows) HOT 2
- Feature request: custom keybindings(?) HOT 1
- Docs: Suggestion to add shell script as a way to open git-cola on mac HOT 4
- Feature: faster and easier commit hash copying in DAG HOT 7
- Feature request: Go up one directory to clone when in a repository HOT 1
- bug: light/dark them dynamic change causes some parts to do not reflect the theme
- Reset dialog should save used value HOT 2
- install & packaging issue on FreeBSD for 4.8.0 HOT 2
- Core dump when right clicking in the extended message textbox HOT 1
- DAG regression: Ctrl+C is always copying the short commit ID, not selected diff text
- DAG crashes immediately after calling on Linux Mint 21.1. As well as when pressing "F1" or "?" HOT 1
- Add `-u` when pushing to remote with a different name HOT 1
- How to set --date-order to be the default in DAG? HOT 1
- (flatpak installation) App won't open. Error message: "qt.glx: qglx_findConfig: Failed to finding matching FBConfig ... (snip)" HOT 2
- Version graph layout problem HOT 1
- FileNotFoundError: [WinError 2] The system cannot find the file specified HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-cola.