Comments (5)
Hmm... Sorry for trouble in upgrading GitBucket. I would recommend upgrading GitBucket versions one by one if behind is very large like your situation. Of course, backup before upgrading is mandatory.
Anyway, thank you for your feedback. I will take a look at them one by one if those issues happen on the latest version.
from gitbucket.
Regarding this point,
In 4.6 when you clicked the Merge Pull Request button it would transform into a confirm button appearing in the same place, so two clicks in a row would perform a merge. In the current version the confirm button has moved to the opposite side of the screen so you must click, move the mouse, and click again--it's less convenient. What's worse, there is now a drop-down button that appears under the mouse after clicking the Merge Pull Request button and in its default state it has the label "Merge commit" which sort of looks like it's the confirm button if you're not paying close attention. This has tripped me up quite a few times and I wish it weren't this way.
- Basically, buttons that execute something should be located to the right bottom of the form
- At first, I thought "Confirm merge" button can be pulldown + button like "Comment" button, however, merge strategy is really important so I thought it's better to be an independent pulldown.
Since I'm not a UI specialist, it would be great if you can propose what it should be.
from gitbucket.
I'm not a UI specialist either, but I sometimes play one at work for lack of anything better. I think the pull down button concept would work well here, but if all you did was move the left-aligned initial Merge button the be right-aligned it would return to being a simple two-click operation without a mouse move.
E.g.
Or do both and use a combo button:
The strategy is important, but it's not something one changes every time. It's the more rare exception.
If you can't figure out something you can be happy with I'd just leave it as-is. This is something that I can get used to even if I don't think it's optimal for me.
I'll end with an aside I should have had in my original comment: it may sound like a complaint, but I actually really like gitbucket and recommend it to people constantly. It's the easiest way to go from zero-to-git-web-ui anywhere and is good enough that many people won't need anything else.
from gitbucket.
Thank you! Locating the initial "Merge pull request" button at right side looks good idea. It's align with our UI policy and minimize move of pointer.
from gitbucket.
I think pull request UI will be improved by #3417. Remaining things are regarding comments in diff view:
- The inline "reply" option exists for comments viewed in the diff view, but the same comments on the Conversation tab have no reply UI.
- If a comment is added on a line and then a force push changes the line and another comment is added to the new line, then when you view the comments from the Conversation tab the second comment chronologically is listed first, then the older one below it. This makes it look like they occurred in the opposite order.
from gitbucket.
Related Issues (20)
- Gitbucket Issue
- [API] File upload does not work properly
- manisat
- Merge pull request creates java.lang.NullPointerException HOT 3
- pull requests / issues - long web loading time HOT 2
- about LFS HOT 1
- gitbucket 4.40 search doesn't work HOT 7
- GitBucket API Insufficient for Dependabot Script HOT 2
- Make line-limit used in showing diff customizable. HOT 2
- "Add labels to an issue" API doesn't work on v4.39.0 HOT 2
- Performance problems with requests to `/api/v3/repos/:owner/:repository/branches`
- Not run with Postgresql 16 HOT 6
- Pull request comments in code disappear after pushing changed commit (force push)
- Unable to create group in gitbucket with springboot api methods HOT 3
- When opening profile page of root user, getting repository not found exception HOT 1
- Error after cloning the repository HOT 10
- Unable to create multiple files in a folder using api. HOT 1
- Performance: JGitUtil.getCommitLog returns too many commits on force-push HOT 2
- Failed to bind station on startup HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitbucket.