Comments (6)
@enhancient both had different beginnings. I started mine for MessageKit and Ryan did his for GitHawk. Ryan has many more followers than me though so this library gained a large following quickly so I wanted to contribute with something I would find useful in GitHawk.
Aside from different origin stories, both have quite different architectures. MessageViewController
is a UIViewController
subclass where was InputBarAccessoryView
is an InputAccessoryView
.
Ryan is really nice about PRs and I'm happy to have one on mine to. If you had to make a choice between the two you would have to look at what you project needs and which is better for it.
Sent with GitHawk
from messageviewcontroller.
Love this project already, love this issue too. I was looking for a lightweight replacement for slacktextviewcontroller. Will be interested to see the vision for the project! <3
from messageviewcontroller.
@eliburke If you are looking for something with more buttons/functionality I suggest you take a look at my repo https://github.com/nathantannar4/InputBarAccessoryView It is what we use at MessageKit
I agree with Ryan in that Table/Collection View should be separate as they shouldn't depend on each other
from messageviewcontroller.
All great questions! And ones that I haven’t put a lot of thought into. I’ll try to work on a vision doc sometime to express my thoughts.
It’s definitely not a total STVC replacement yet. There are missing features like edit mode and left buttons. But for a simple resizing text view for messaging, this is pretty much all you need.
I don’t plan on adding any messaging functionality to this project as I think that implementing table or collection views should be completely decoupled from an input text view (prob my biggest gripe with STVC).
Really great questions, I’m glad you asked!
Sent with GitHawk
from messageviewcontroller.
@nathantannar4 InputBarAccessoryView looks great - so why doesn't this project leverage that work considering you are a collaborator on this project? If I use InputBarAccessoryView now for the extra buttons functionality that I need, will I be wanting to migrate across to MessageViewController in a few months when that's added here in this project? I also need an edit mode, so if I develop that, which project is most likely to take a merge request?
from messageviewcontroller.
@nathantannar4 thanks, that's useful 👍
from messageviewcontroller.
Related Issues (20)
- Make the attachment button do something HOT 2
- Improve autocomplete view accessibility
- Inconsistent text view font HOT 20
- Improve hit area for send button HOT 1
- Add accessibility information to the send button HOT 4
- Autocomplete feature only HOT 7
- Not respecting bottom inset when adjusting offset for keyboard HOT 2
- messageView.font seems to not be working? HOT 4
- How to integrate MessageViewController with MessageKit or JSQMessageViewController HOT 6
- Insets not respecting tabBarController height HOT 2
- Buttons don't align vertically with textInputView HOT 1
- Should setting messageView.text trigger textDidChange delegate methods? HOT 1
- Autocomplete in landscape gets cut off
- 26 error on Swift 4.2 on Xcode 10 HOT 2
- How to remove the animation HOT 15
- Enable/Disable the Send/Right button
- Release 0.3 HOT 1
- How to change textColor or TextView. Scroll issue when started typing.
- Wear behavior when one starts tapping the keyboard. There is some error on the code. Please, can someone take a look inside the addObservers function?
- Weird issue when started typing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from messageviewcontroller.