Giter VIP home page Giter VIP logo

Comments (11)

benbalter avatar benbalter commented on July 17, 2024

This would have to be bumped within Jekyll itself, as it's currently limited to < 1.3, but once done, this Gem's version would be bumped with the next Jekyll release.

from pages-gem.

CHH avatar CHH commented on July 17, 2024

Should I open an issue on Jekyll?

from pages-gem.

benbalter avatar benbalter commented on July 17, 2024

Yep. That'd be the best way to get it updated here. Thanks. 😄

from pages-gem.

CHH avatar CHH commented on July 17, 2024

Done. 😄

from pages-gem.

CHH avatar CHH commented on July 17, 2024

@benbalter After thinking this through I think this is mainly an issue with GitHub Pages locking the version tightly to 1.2. Jekyll doesn't restrict it to 1.2 with ~> 1.2. If I put in gem "kramdown", "~>1.3" in my local Gemfile I get 1.3 and everything works as expected. So this would have to be only changed in the gem spec of the pages-gem, as the Converter in Jekyll doesn't need to be modified (because it passes the whole options hash straight through to Kramdown).

from pages-gem.

benbalter avatar benbalter commented on July 17, 2024

You're right. For some reason I thought Kramdown was semantically versioned. Would you be able to put together a pull request with the gem bump?

from pages-gem.

CHH avatar CHH commented on July 17, 2024

@benbalter #38, here it is :-)

from pages-gem.

CHH avatar CHH commented on July 17, 2024

Build passes: https://travis-ci.org/github/pages-gem/builds/16161534

from pages-gem.

benbalter avatar benbalter commented on July 17, 2024

🤘. Thanks. Have to run a few additionally checks internally, but assuming everything's green, will get the github-pages gem bumped and deployed.

from pages-gem.

CHH avatar CHH commented on July 17, 2024

Great! Thanks! 😄

from pages-gem.

CHH avatar CHH commented on July 17, 2024

@benbalter can you give me an ETA when this will be ready?

from pages-gem.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.