Comments (5)
I have a refactor PR that’ll be ready soon which will resolve these without regressing the other cases we’ve run into.
from relative-time-element.
Same issue on https://github.com/grayjoking/backhand (flagged up by user):
from relative-time-element.
Here’s a test case that illustrates the issue:
--- a/test/relative-time.js
+++ b/test/relative-time.js
@@ -2411,18 +2411,18 @@ suite('relative-time', function () {
expected: 'in 3 years',
},
{
- reference: '2022-12-31T12:00:00.000Z',
- datetime: '2024-03-01T12:00:00.000Z',
- tense: 'future',
- format: 'micro',
- expected: '3y',
+ reference: '2023-02-18T19:00:00.000Z',
+ datetime: '2021-02-02T20:49:31.000Z',
+ tense: 'past',
+ format: 'auto',
+ expected: '2 years ago',
},
{
- reference: '2021-04-24T12:00:00.000Z',
- datetime: '2023-02-01T12:00:00.000Z',
- tense: 'future',
- format: 'micro',
- expected: '2y',
+ reference: '2023-02-18T19:00:00.000Z',
+ datetime: '2021-01-23T09:28:06.000Z',
+ tense: 'past',
+ format: 'auto',
+ expected: '2 years ago',
},
])
Output:
test/relative-time.js:
❌ relative-time > legacy formats > <relative-time datetime="2021-02-02T20:49:31.000Z" tense="past" format="auto" > => 2 years ago
AssertionError: expected '3 years ago' to equal '2 years ago'
+ expected - actual
-3 years ago
+2 years ago
Might be related to #249? cc @keithamus
from relative-time-element.
@keithamus currently I am trying to dive into the code. Could you please point me to the PR with the refactoring?
from relative-time-element.
I did some work on trying to create a polyfill for Temporal Durations so we could move to those but the work stalled due to the complexity of the Temporal APIs. I don't have an active branch or PR so the current code is the latest iteration.
from relative-time-element.
Related Issues (20)
- Format attribute does not respect lang HOT 3
- Make `format` API more consistent
- datetime without weekday HOT 2
- Package no longer publishing to NPM? HOT 3
- Not exactly sure of what, but something appears to be wrong?
- Precision for what to display HOT 3
- The `on` prefix is not localized HOT 3
- Attribute to control which attribute is set for `title` HOT 2
- Text selection bugs in Firefox HOT 5
- Enable passing `formatStyle` to Intl.DateTimeFormat HOT 1
- Stray days added to duration HOT 1
- Stricter `datetime` validation HOT 4
- sdfgvb
- Cannot get format=relative to display seconds HOT 2
- "X years ago" is not rounding correctly HOT 3
- Title format is not configurable
- Render 12/24 hour format according to user's preference HOT 4
- precision=day should return "today" instead of "now" HOT 1
- Feb 29th showing as 'yesterday' on March 31 HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from relative-time-element.