RHC using wrong get_fitness? about mlrose HOT 5 CLOSED

I have the same problem. I think random_climb, random_hill_climb , and simulated_annealing should use get_fitness instead. genetic_alg and mimic still uses get_pop_fitness as implemented.

get_fitness returns the fitness value of the current state.
get_pop_fitness returns the fitness values of the states of the current population. "Population" is only relevant in mimic and genetic_alg, I believe.

I'll make a quick fix to see how that goes.

from mlrose.

random_climb? or hill_climb? I think hill_climb should have implemented it correctly from what I see? And yeah, SA should be updated with the same fix.
Oh and I also made a pull request so you can check it with that fork. I verified that it works...so far!

from mlrose.

Yeah, you're right. hill_climb had it correct already.

from mlrose.

Ahh I also made the same PR. 😄 I'll close mine.

from mlrose.

I have just merged @nibelungvalesti 's pull request that fixes this issue, so am closing this.
Thanks to @nibelungvalesti and @daivinhtran for pointing it out.
Regards,
Genevieve.

from mlrose.