Currently you use the specific beautifiers settings (ie js is 2) when my editor is set

+1 <a target="_blank" rel="noopener noreferrer nofollow" href="https://cloud.githu

Use atom editor settings for indentation level about atom-beautify HOT 3 CLOSED

glavin001 commented on May 22, 2024

Use atom editor settings for indentation level

from atom-beautify.

Comments (3)

Glavin001 commented on May 22, 2024

from atom-beautify.

Glavin001 commented on May 22, 2024

I was going to fix this when I realized that the code is already in place:

atom-beautify/lib/atom-beautify.js

Lines 183 to 192 in 04a23a0

 var editor = atom.workspace.getActiveEditor(); 

 var isSelection = !!editor.getSelectedText(); 

 var softTabs = editor.softTabs; 

 var tabLength = editor.getTabLength(); 

 var editorOptions = { 

 'indent_size': softTabs ? tabLength : 1, 

 'indent_char': softTabs ? ' ' : '\t', 

 'indent_with_tabs': !softTabs 

 };

This will correctly pull the the editorOptions and use them as the base. What I believe is really happening is that they are being overridden, intentionally, by the atom-beautify package settings.
The order can be found here:

atom-beautify/lib/atom-beautify.js

Lines 249 to 257 in 04a23a0

 // All of the options 

 // Listed in order from default (base) to the one with the highest priority 

 // Left = Default, Right = Will override the left. 

 var allOptions = [ 

 editorOptions, // Atom Editor 

 configOptions, // 

 homeOptions, // User's Home path 

 projectOptions // Project path 

 ];

So in the end, I suppose you can say, this is actually intentional and expected because of the order of precedence with the configuration options. There's nothing I can really do because it is truly working as expected: the more specific and ideally accurate variables set in the atom-beautify package settings will always override the options of the editor and I could simply re-order it such that the editor settings have higher priority however they really do not. I want the atom-beautify package settings to take precedence.

I will look into potentially having the default (unset) values for the atom-beautify package settings to be the equivalent of the editor's settings. That'd be a good solution 👍

from atom-beautify.

Glavin001 commented on May 22, 2024

I can retrieve the value with atom.config.get('editor.tabLength'). However, it is unlikely that I will resolve this as the atom-beautify settings has settings for each supported language and should be used and enforced in these cases. Thanks for bringing this to my attention though. For now, use the package settings.

from atom-beautify.

Recommend Projects

Use atom editor settings for indentation level about atom-beautify HOT 3 CLOSED

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	var editor = atom.workspace.getActiveEditor();
	var isSelection = !!editor.getSelectedText();

	var softTabs = editor.softTabs;
	var tabLength = editor.getTabLength();
	var editorOptions = {
	'indent_size': softTabs ? tabLength : 1,
	'indent_char': softTabs ? ' ' : '\t',
	'indent_with_tabs': !softTabs
	};

	// All of the options
	// Listed in order from default (base) to the one with the highest priority
	// Left = Default, Right = Will override the left.
	var allOptions = [
	editorOptions, // Atom Editor
	configOptions, //
	homeOptions, // User's Home path
	projectOptions // Project path
	];