Library functions string.inspect and io.debug don't escape newlines, carriage returns, tabs, or backslashes. about stdlib HOT 5 CLOSED

Having been pointed at gleam.mjs I can see it uses JSON.stringify.

Quick interactive testing on the MDN page for JSON.stringify makes clear that all five special characters are properly escaped. I don't know if Node does anything differently, but assuming not mean this is incompatible behaviour between the two targets.

from stdlib.

Thank you. Let's get this fixed

from stdlib.

I'm not able to do this properly right now, but I was curious so I made a little test project that had only the relevant bits of gleam_stdlib.erl and fumbled with the Erlang docs for a bit. Replacing as follows seemed to do the trick:

% At line 349: %
% --- %
% Pattern = [$"],
% Replacement = [$\\, $\\, $&],
% Escaped = re:replace(Binary, Pattern, Replacement, [{return, binary}, global]),
% ["\"", Escaped, "\""];
% --- %
% +++ %
EscapedWithAngles = io_lib:format("~p", [Binary]),
lists:nth(3, hd(EscapedWithAngles));
% +++ %

This avoids doing a pass for each type of escaped character and, at least for the obvious tests I threw at it, works. If I've missed a subtle edge-case, or used something about the returned value of io_lib:format I shouldn't, or otherwise committed an Erlang crime... please teach me!

from stdlib.

@DanielSherlock thanks I will take a look.

from stdlib.

Sorry, I took so long to type that out you'd basically fixed it in the mean time. I commented on the PR too, but after all that I like the clear way your solution reads and it means we don't have to worry about whether io_lib:format always returns something of the same shape.

from stdlib.