Possibly unnecessary condition check about libpng HOT 5 CLOSED

from libpng.

Problem seems to exist only in the libpng16 branch.

from libpng.

Reopening this issue because there are two more checks that could be omitted.

File pngrutil.c, line 1588:
else if (size > 0)
Unsigned variable is not equal to 0, therefore the condition is always true. Though it could be left as a comment.

File pngwrite.c, line 1943:
int write_16bit = linear && !colormap && (display->convert_to_8bit == 0);
!colormap was already evaluated in linear variable.

from libpng.

Agreed about !colormap.
The "size > 0" gave some trouble with Coverity so I'm not so sure about that.
I'll make a Coverity run with the change now and see what happens.

from libpng.

Looking at the old code in pngrutil.c it might be expected to see:

#ifndef __COVERITY__
                                    errmsg = png_ptr->zstream.msg;
#endif
                                }
                               else
                                   errmsg = "truncated";

from libpng.