Giter VIP home page Giter VIP logo

Comments (7)

progrium avatar progrium commented on July 19, 2024

What makes you think it's not possible? What have you tried?

On Wed, Mar 11, 2015 at 2:44 PM, discordianfish [email protected]
wrote:

Hi,

I want to change the consul domain which isn't possible with this docker
image.
I'm happy to contribute the necessary changes, just let me know if you
have some ideas how.
I would probably modify the json as part of the run script or something..?


Reply to this email directly or view it on GitHub
#62.

Jeff Lindsay
http://progrium.com

from docker-consul.

discordianfish avatar discordianfish commented on July 19, 2024

Well it requires changes to config/consul.json which isn't possible by just passing env variables or parameters to the container. Sure, I can create a image using yours as base image, but given that the domain is a pretty common option to change (at least I assume), it would be good to have support for that in your image. But if you disagree, I'll just go that route and you can close the issue.

from docker-consul.

thpham avatar thpham commented on July 19, 2024

I also need to change the domain, but as @discordianfish said, it's impossible to start the server with -domain argument, the only way it to have it through consul.json

+1 for this feature please, thanks

from docker-consul.

discordianfish avatar discordianfish commented on July 19, 2024

I've just opened this PR to solve this in consul itself: hashicorp/consul#805

from docker-consul.

joshskinner avatar joshskinner commented on July 19, 2024

I just ran into this as well. Interesting that the consul config is disconnected in features from the command line. Nice job getting it in @discordianfish! Looking forward to the next release of Consul so we can utilize this feature. Thanks also to @progrium to putting this together in the first place!

from docker-consul.

ankushagarwal avatar ankushagarwal commented on July 19, 2024

Is this still a problem? I was able to add the -domain mydomain.com option during docker run and it worked

from docker-consul.

discordianfish avatar discordianfish commented on July 19, 2024

Yes, I think this is fixed with the current consul version in the image.

from docker-consul.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.