Giter VIP home page Giter VIP logo

Comments (5)

vecna avatar vecna commented on May 21, 2024

There are two possible solution:

@hellais at the moment, the receiver, need a name for be create (POST) and then the update for be completed (PUT). In order to enforce username/mail, password fields, it's required change the client UX interaction, and perform with the creation operation only when the required fields are filled.

Or, without change the client interaction, can be created a status/marker in the receiver, like activate flag, and until the fields are not available, it's not possible activate the receiver.

This latest option it's probably required in the future, because receiver need to be handled with he status of "password lockdown" (and would mean, more or less, like the activate flag is set to False. When reactivated by the Admin, a new activation mail can be sent). And this latest option can be implemented without @hellais effort in change client UX.

from globaleaks.

fpietrosanti avatar fpietrosanti commented on May 21, 2024

I'd prefer to goes for the quickest solution, just to make the fields enforced on GLC and GLB.

Password lockout is a feature not currently provided for testing in the functional workflow.
I'm going to create a ticket of type "enhancement" to remind about this feature,requiring to touch many places in the code:

  • the admin configuration of lockout
  • the UI visualization on failed attempt (the user must be informed that he has remaining X passwords while typing)
  • the concept of receiver activated/deactivated
  • the logging of the security incident

from globaleaks.

hellais avatar hellais commented on May 21, 2024

I have made some changes to the UI of the add receivers so that it's no longer possible to add a receiver without an email address.

This is how it looks like:

Screen Shot 2013-02-23 at 8 26 57 PM

from globaleaks.

fpietrosanti avatar fpietrosanti commented on May 21, 2024

I remove GLClient tag from the ticket, now it's only a GLB issue to be enforced.

from globaleaks.

vecna avatar vecna commented on May 21, 2024

done in https://github.com/globaleaks/GLBackend/commit/025f3cafa654d1849b268a72a87647eace775bf3 with unitTest and receiver notification_fields, too

from globaleaks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.