Comments (5)
There are two possible solution:
@hellais at the moment, the receiver, need a name for be create (POST) and then the update for be completed (PUT). In order to enforce username/mail, password fields, it's required change the client UX interaction, and perform with the creation operation only when the required fields are filled.
Or, without change the client interaction, can be created a status/marker in the receiver, like activate flag, and until the fields are not available, it's not possible activate the receiver.
This latest option it's probably required in the future, because receiver need to be handled with he status of "password lockdown" (and would mean, more or less, like the activate flag is set to False. When reactivated by the Admin, a new activation mail can be sent). And this latest option can be implemented without @hellais effort in change client UX.
from globaleaks.
I'd prefer to goes for the quickest solution, just to make the fields enforced on GLC and GLB.
Password lockout is a feature not currently provided for testing in the functional workflow.
I'm going to create a ticket of type "enhancement" to remind about this feature,requiring to touch many places in the code:
- the admin configuration of lockout
- the UI visualization on failed attempt (the user must be informed that he has remaining X passwords while typing)
- the concept of receiver activated/deactivated
- the logging of the security incident
from globaleaks.
I have made some changes to the UI of the add receivers so that it's no longer possible to add a receiver without an email address.
This is how it looks like:
from globaleaks.
I remove GLClient tag from the ticket, now it's only a GLB issue to be enforced.
from globaleaks.
done in https://github.com/globaleaks/GLBackend/commit/025f3cafa654d1849b268a72a87647eace775bf3 with unitTest and receiver notification_fields, too
from globaleaks.
Related Issues (20)
- Ubuntu "Network unreachable" - Let's Encrypt renewal failure - After Globaleaks update the system not work HOT 4
- Potential Log issue - whistlebloser seems to log in very often HOT 2
- Expiration date change only applied to new reports HOT 3
- custom route for sites instead of the id HOT 2
- Ability to disable Account Recovery Key – Increased focus on 2FA HOT 1
- Internal server error when exporting and importing questionnaire on same instance HOT 5
- Sending notification mails via Globaleaks SMTP seems to fail on the ".consulting" TLD HOT 4
- When exporting a report the various dates within the report (e.g. calendar entries, time stamps) may differentiate from what the recipient sees. HOT 3
- The whistleblower login key code box in the submissions and individual context page has disappeared HOT 5
- Improvements for analyst role HOT 1
- Can't send mails with internal SMTP server HOT 1
- Contact details of Whistleblower can not be masked HOT 1
- Custom css and initialization is not executed when using relative paths, www.domain.com/myglobaleaks HOT 2
- Service failed to start after ubuntu update HOT 11
- Backups HOT 1
- Info text when hovering for private/public/only recipients-channels HOT 2
- Update - Signature Verification HOT 4
- [Solved] Can't access GL after update HOT 2
- Mandatory fields on "Report page" are not enforced HOT 2
- Tor task higly increases CPU load HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from globaleaks.