Comments (2)
charnet1019
commented on May 22, 2024
Same issue. Are you fixed it?
from gluster-ansible-infra.
liutaurasa
commented on May 22, 2024
I could bypass the issue adding pvs key to all lvm definitions and fixing ansible tasks in few places.
Below is my configuration (removed config of other nodes as they are identical to node1, so no need to show it here).
Please note that elements in gluster_infra_thick_lvs, gluster_infra_thinpools and gluster_infra_lv_logicalvols arrays have pvs keys.
hc_nodes:
hosts:
node1:
gluster_infra_volume_groups:
- vgname: vg_nvme
pvname: /dev/nvme0n1
- vgname: vg_sata
pvname: /dev/sda
- vgname: vg_infra
pvname: /dev/md3
gluster_infra_mount_devices:
- path: /gluster_bricks/engine
lvname: lv_engine
vgname: vg_infra
- path: /gluster_bricks/data-sata
lvname: lv_data
vgname: vg_sata
- path: /gluster_bricks/vmstore-sata
lvname: lv_vmstore
vgname: vg_sata
- path: /gluster_bricks/data-nvme
lvname: lv_data
vgname: vg_nvme
- path: /gluster_bricks/vmstore-nvme
lvname: lv_vmstore
vgname: vg_nvme
blacklist_mpath_devices:
- nvme0n1
- nvme1n1
- nvme2n1
- sda
- md3
#gluster_infra_cache_vars:
# - vgname: vg_sata
# cachedisk: /dev/md3
# cachelvname: lv_cache
# cachetarget: thinpool_vg_sata
# cachelvsize: 5G
# cachemode: writethrough
gluster_infra_thick_lvs:
- vgname: vg_infra
lvname: lv_engine
size: 100G
pvs: /dev/md3
gluster_infra_thinpools:
- vgname: vg_nvme
thinpoolname: thinpool_nvme
thinpoolsize: 100G
poolmetadatasize: 3G
pvs: /dev/nvme0n1
- vgname: vg_sata
thinpoolname: thinpool_sata
thinpoolsize: 1T
poolmetadatasize: 3G
pvs: /dev/sda
gluster_infra_lv_logicalvols:
- vgname: vg_sata
thinpool: thinpool_sata
lvname: lv_data
lvsize: 1T
pvs: /dev/sda
- vgname: vg_nvme
thinpool: thinpool_nvme
lvname: lv_data
lvsize: 200G
pvs: /dev/nvme0n1
- vgname: vg_sata
thinpool: thinpool_sata
lvname: lv_vmstore
lvsize: 1T
pvs: /dev/sda
- vgname: vg_nvme
thinpool: thinpool_nvme
lvname: lv_vmstore
lvsize: 200G
pvs: /dev/nvme0n1
...
here is the diff of changes I've made to backend_setuo tasks:
diff -Nupr ./cache_setup.yml /etc/ansible/roles/gluster.infra/roles/backend_setup/tasks/cache_setup.yml
--- ./cache_setup.yml 2023-03-23 09:46:02.693167826 +0100
+++ /etc/ansible/roles/gluster.infra/roles/backend_setup/tasks/cache_setup.yml 2023-03-24 13:07:08.867586480 +0100
@@ -7,7 +7,7 @@
# caching)
- name: Extend volume group
- command: "vgextend --dataalignment 256K {{ item.vgname }} {{ item.cachedisk.split(',')[1] }}"
+ command: "vgextend --dataalignment 256K {{ item.vgname }} {{ item.cachedisk.split(',')[0] }}"
# lvg:
# state: present
# vg: "{{ item.vgname }}"
@@ -29,7 +29,7 @@
- name: Create LV for cache
ansible.builtin.expect:
- command: "lvcreate -L {{ item.cachelvsize }} -n {{ item.cachelvname }} {{ item.vgname }}"
+ command: "lvcreate --yes -L {{ item.cachelvsize }} -n {{ item.cachelvname }} {{ item.vgname }}"
responses:
(.*)WARNING:(.*): "y"
# lvol:
@@ -40,7 +40,7 @@
with_items: "{{ gluster_infra_cache_vars }}"
- name: Create metadata LV for cache
- command: "lvcreate -L {{ item.cachemetalvsize }} -n {{ item.cachemetalvname }} {{ item.vgname }}"
+ command: "lvcreate --yes -L {{ item.cachemetalvsize }} -n {{ item.cachemetalvname }} {{ item.vgname }}"
# lvol:
# state: present
# vg: "{{ item.vgname }}"
diff -Nupr ./thick_lv_create.yml /etc/ansible/roles/gluster.infra/roles/backend_setup/tasks/thick_lv_create.yml
--- ./thick_lv_create.yml 2023-03-23 09:46:02.693167826 +0100
+++ /etc/ansible/roles/gluster.infra/roles/backend_setup/tasks/thick_lv_create.yml 2023-03-24 13:07:08.868586483 +0100
@@ -26,7 +26,6 @@
{%- set output=[] -%}
{%- for cnf in gluster_infra_thick_lvs -%}
{%- if cnf is defined and cnf is not none and cnf.vgname is defined
- and (cnf.pvs is defined)
-%}
{{- output.append({"vgname": cnf.vgname, "raid": cnf.raid | default() , "pvname": (cnf.pvs|default('')).split(',') | select | list | unique | join(',')}) -}}
{%- endif -%}
@@ -50,7 +49,7 @@
{%- endif -%}
{%- else -%}
{{- 4 -}}
- {%- endif -%} {{ (item.value | first).vgname }} {{ item.value | json_query('[].pvname') | unique | join(',') }} {% if (item.value | first).raid is defined and (item.value | first).raid is not none
+ {%- endif %} {{ (item.value | first).vgname }} {{ item.value | json_query('[].pvname') | unique | join(',') }} {% if (item.value | first).raid is defined and (item.value | first).raid is not none
and (item.value | first).raid.level is defined and (item.value | first).raid.devices is defined and (item.value | first).raid.stripe is defined
and (item.value | first).raid.level in [0,5,6,10]%}
{% if (item.value | first).raid.level == 0 %}
@@ -102,6 +101,7 @@
# {%- else -%}
# {{- 4 -}}
# {%- endif -%}
+ failed_when: gluster_changed_vgs.rc is defined and gluster_changed_vgs.rc not in [0, 3, 5]
loop: "{{ gluster_volumes_by_groupname | dict2items if gluster_volumes_by_groupname is defined and gluster_volumes_by_groupname is not none else [] }}"
loop_control:
index_var: index
@@ -116,7 +116,7 @@
# Create a thick logical volume.
- name: Create thick logical volume
- command: "lvcreate -L {{ item.size | default('100%FREE') }} -n {{ item.lvname }} {{ item.pvs | default() }} {{ item.vgname }} "
+ command: "lvcreate --yes -L {{ item.size | default('100%FREE') }} -n {{ item.lvname }} {{ item.vgname }} {{ item.pvs | default() }} "
#lvol:
# state: present
# vg: "{{ item.vgname }}"
@@ -126,6 +126,8 @@
# opts: "{{ item.opts | default() }}"
# shrink: "{{ item.shrink if item.shrink is defined and item.shrink is not none else true }}"
with_items: "{{ gluster_infra_thick_lvs }}"
+ register: lvcreate_results
+ failed_when: lvcreate_results.rc is defined and lvcreate_results.rc not in [0, 5]
loop_control:
index_var: index
when: item is not none and lv_device_exists.results[index].stdout_lines is defined and "0" not in lv_device_exists.results[index].stdout_lines
diff -Nupr ./thin_pool_create.yml /etc/ansible/roles/gluster.infra/roles/backend_setup/tasks/thin_pool_create.yml
--- ./thin_pool_create.yml 2023-03-23 09:46:02.693167826 +0100
+++ /etc/ansible/roles/gluster.infra/roles/backend_setup/tasks/thin_pool_create.yml 2023-03-24 13:07:08.867586480 +0100
@@ -63,7 +63,6 @@
{%- for cnf in gluster_infra_thinpools -%}
{%- if cnf is defined and cnf is not none and cnf.thinpoolname is defined and cnf.vgname is defined
and (thinpool_attrs.results[loop.index0].stdout is not defined or thinpool_attrs.results[loop.index0].stdout.find("t") != 0)
- and (cnf.meta_pvs is defined or cnf.pvs is defined)
-%}
{{- output.append({"vgname": cnf.vgname, "pvname": (cnf.pvs|default('') ~ ',' ~ (cnf.meta_pvs|default(''))).split(',') | select | list | unique | join(',')}) -}}
{%- endif -%}
@@ -91,7 +90,7 @@
{%- endif -%}
{%- else -%}
{{- 4 -}}
- {%- endif -%} {{ (item.value | first).vgname }} {{ item.value | json_query('[].pvname') | unique | join(',') }} {% if (item.value | first).raid is defined and (item.value | first).raid is not none
+ {%- endif %} {{ (item.value | first).vgname }} {{ item.value | json_query('[].pvname') | unique | join(',') }} {% if (item.value | first).raid is defined and (item.value | first).raid is not none
and (item.value | first).raid.level is defined and (item.value | first).raid.devices is defined and (item.value | first).raid.stripe is defined
and (item.value | first).raid.level in [0,5,6,10]%}
{% if (item.value | first).raid.level == 0 %}
@@ -143,6 +142,7 @@
# {%- else -%}
# {{- 4 -}}
# {%- endif -%}
+ failed_when: gluster_changed_vgs.rc is defined and gluster_changed_vgs.rc not in [0, 3, 5]
loop: "{{ gluster_volumes_by_groupname | dict2items }}"
loop_control:
index_var: index
@@ -156,7 +156,7 @@
when: gluster_changed_vgs.changed
- name: Create a LV thinpool-data
- command: "lvcreate -l {{ item.thinpoolsize | default('100%FREE') }} --options {{ item.opts | default('') }} -n {{ item.thinpoolname }} {{ item.pvs | default() }} {{ item.vgname }} "
+ command: "lvcreate --yes -l {{ item.thinpoolsize | default('100%FREE') }} --options {{ item.opts | default('') }} -n {{ item.thinpoolname }} {{ item.pvs | default() }} {{ item.vgname }} "
# lvol:
# state: present
# shrink: false
@@ -178,7 +178,7 @@
- name: Create a LV thinpool-meta
- command: "lvcreate -l {{ item.poolmetadatasize | default('16G') }} --options {{ ((item.meta_opts is defined and item.meta_opts) or item.opts) | default('') }} -n {{ item.thinpoolname }}_meta {{ ((item.meta_pvs is defined and item.meta_pvs) or item.pvs) | default() }} {{ item.vgname }} "
+ command: "lvcreate --yes -l {{ item.poolmetadatasize | default('16G') }} --options {{ ((item.meta_opts is defined and item.meta_opts) or item.opts) | default('') }} -n {{ item.thinpoolname }}_meta {{ ((item.meta_pvs is defined and item.meta_pvs) or item.pvs) | default() }} {{ item.vgname }} "
# lvol:
# state: present
# shrink: false
@@ -232,7 +232,7 @@
- name: Create a LV thinpool
- command: "lvcreate {% if item.thinpoolsize is defined %} -L {{ item.thinpoolsize }} {% else %} -l 100%FREE {% endif %} --options {% if item.raid is defined and item.raid is not none
+ command: "lvcreate --yes {% if item.thinpoolsize is defined %} -L {{ item.thinpoolsize }} {% else %} -l 100%FREE {% endif %} --options {% if item.raid is defined and item.raid is not none
and item.raid.level is defined and item.raid.devices is defined and item.raid.stripe is defined
and item.raid.level in [0,5,6,10]%}
{% if item.raid.level == 0 %}
@@ -286,7 +286,7 @@
#end-block
- name: Create a LV thinpool for similar device types
- command: "lvcreate --type thin-pool --zero n {% if item.thinpoolsize is defined %} -L {{ item.thinpoolsize }} {% else %} -l 100%FREE {% endif %} --chunksize {{ lv_chunksize }} --poolmetadatasize {{ item.poolmetadatasize + \"iB\" }} -n {{ item.thinpoolname }} {{ item.vgname }} "
+ command: "lvcreate --yes --type thin-pool --zero n {% if item.thinpoolsize is defined %} -L {{ item.thinpoolsize }} {% else %} -l 100%FREE {% endif %} --chunksize {{ lv_chunksize }} --poolmetadatasize {{ item.poolmetadatasize + \"iB\" }} -n {{ item.thinpoolname }} {{ item.vgname }} "
# lvol:
# state: present
# shrink: false
@@ -296,6 +296,8 @@
# opts: " --chunksize {{ lv_chunksize }}
# --poolmetadatasize {{ item.poolmetadatasize }}
# --zero n"
+ register: lvcreate_thin_pools_results
+ failed_when: lvcreate_thin_pools_results.rc is defined and lvcreate_thin_pools_results.rc not in [0, 5]
with_items: "{{ gluster_infra_thinpools }}"
when: gluster_infra_thinpools is defined and item.raid is not defined
diff -Nupr ./thin_volume_create.yml /etc/ansible/roles/gluster.infra/roles/backend_setup/tasks/thin_volume_create.yml
--- ./thin_volume_create.yml 2023-03-23 09:46:02.693167826 +0100
+++ /etc/ansible/roles/gluster.infra/roles/backend_setup/tasks/thin_volume_create.yml 2023-03-24 13:07:08.867586480 +0100
@@ -61,6 +61,7 @@
# vg: "{{ (item.value | first).vgname }}"
# pvs: "{{ item.value | json_query('[].pvname') | unique | join(',') }}"
# pv_options: "--dataalignment 256K"
+ failed_when: gluster_changed_vgs.rc is defined and gluster_changed_vgs.rc not in [0, 3, 5]
loop: "{{ gluster_volumes_by_groupname | dict2items }}"
loop_control:
index_var: index
@@ -75,7 +76,7 @@
- name: Create a LV thinlv-data
- command: "lvcreate -l {{ item.lvsize | default('100%FREE') }} --options {{ item.opts | default('') }} -n {{ item.lvname }} {{ item.pvs | default() }} {{ item.vgname }} "
+ command: "lvcreate --yes -l {{ item.lvsize | default('100%FREE') }} --options {{ item.opts | default('') }} -n {{ item.lvname }} {{ item.pvs | default() }} {{ item.vgname }} "
# lvol:
# state: present
# shrink: false
@@ -86,6 +87,8 @@
# opts: "
# {{ item.opts | default('') }} "
with_items: "{{ gluster_infra_lv_logicalvols }}"
+ register: lvcreate_results
+ failed_when: lvcreate_results.rc is defined and lvcreate_results.rc not in [0, 5]
loop_control:
index_var: index
when: >
@@ -96,7 +99,7 @@
- name: Create a LV thinlv-meta
- command: "lvcreate -l {{ item.meta_size | default('16G') }} --options {{ ((item.meta_opts is defined and item.meta_opts) or item.opts) | default('') }} -n {{ item.lvname }}_meta {{ ((item.meta_pvs is defined and item.meta_pvs) or item.pvs) | default() }} {{ item.vgname }} "
+ command: "lvcreate --yes -l {{ item.meta_size | default('16G') }} --options {{ ((item.meta_opts is defined and item.meta_opts) or item.opts) | default('') }} -n {{ item.lvname }}_meta {{ ((item.meta_pvs is defined and item.meta_pvs) or item.pvs) | default() }} {{ item.vgname }} "
# lvol:
# state: present
# shrink: false
@@ -107,6 +110,8 @@
# opts: "
# {{ ((item.meta_opts is defined and item.meta_opts) or item.opts) | default('') }} "
with_items: "{{ gluster_infra_lv_logicalvols }}"
+ register: lvcreate_results
+ failed_when: lvcreate_results.rc is defined and lvcreate_results.rc not in [0, 5]
loop_control:
index_var: index
when: >
@@ -133,7 +138,7 @@
#this fails when the pool doesn't exist
- name: Create thin logical volume
- command: "lvcreate -T {{ item.vgname }}/{{ item.thinpool }} -V {{ item.lvsize }} -n {{ item.lvname }}"
+ command: "lvcreate --yes -T {{ item.vgname }}/{{ item.thinpool }} -V {{ item.lvsize }} -n {{ item.lvname }}"
# lvol:
# state: present
# vg: "{{ item.vgname }}"
@@ -145,6 +150,8 @@
# opts: >
# {{ item.opts | default() }}
with_items: "{{ gluster_infra_lv_logicalvols }}"
+ register: lvcreate_results
+ failed_when: lvcreate_results.rc is defined and lvcreate_results.rc not in [0, 5]
loop_control:
index_var: index
when: >
diff -Nupr ./vg_create.yml /etc/ansible/roles/gluster.infra/roles/backend_setup/tasks/vg_create.yml
--- ./vg_create.yml 2023-03-23 09:46:02.693167826 +0100
+++ /etc/ansible/roles/gluster.infra/roles/backend_setup/tasks/vg_create.yml 2023-03-23 15:38:34.445005209 +0100
@@ -70,6 +70,7 @@
# pv_options: "--dataalignment {{ item.value.pv_dataalign | default(pv_dataalign) }}"
# pesize is 4m by default for JBODs
# pesize: "{{ vg_pesize | default(4) }}"
+ failed_when: gluster_changed_vgs.rc is defined and gluster_changed_vgs.rc not in [0, 3, 5]
loop: "{{gluster_volumes_by_groupname | default({}) | dict2items}}"
when: gluster_volumes_by_groupname is defined and item.value|length>0
from gluster-ansible-infra.
Related Issues (20)
- gluster_infra_lv_logicalvols['lvsize'] is not optional and doesn't default to 100% of LV
- Unconditionally applying '--maxDiscardSize 16M' on VDO in Gluster HCI breaks CentOS7 deployments
- Getting error while executing task gluster.infra/roles/backend_setup HOT 3
- Script are failing as the updated gluster-ansible requires vdsm-tools to be installed HOT 9
- cachethinpoolname is required instead of deprecated
- gluster.infra package throwing error for firewall_config HOT 3
- vdsm-python package on Debian based systems HOT 1
- Task ensures multipathd is started, and enabled, but should this be systemd? HOT 2
- backend-setup role fails on rhel7
- python-yaml package name changed to python3-yaml on debian bullseye HOT 1
- backend_setup role fails with invalid argument for `lvcreate` HOT 4
- Move to lvol module?
- vg_create is not idempotent HOT 11
- issue with VDO
- backend_setup role fails with ansible-core 2.13.3 and Python 3.9 HOT 3
- Create directory in new bricks HOT 2
- Why is RAID1 not an option?
- gluster_volumes_by_groupname_pre NoneNoneNone
- gluster.infra fails because lvm2 package is not installed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gluster-ansible-infra.