Decouple from Pimple about php-mattermost-driver HOT 5 OPEN

Hi @akuzia, @tacman,
these are very good changes.

I think we should bump the version and make all possible improvements before tagging the 3.0.0, e.g. require php8.
I will check the pull requests and look for other possible breaking changes to bring in.

from php-mattermost-driver.

Hi @bradjones1, thanks for forcing me to think about this.
You're totally right, this package should follow a more SOLID approach.

I'm thinking of changing the constructor as follows

public function __construct(array $options[])

rather than

public function __construct(Psr\Container\ContainerInterface $container)

What do you think? Do you have any suggestions?

from php-mattermost-driver.

@gnello I've made a fork removing pimple and switching from Guzzle to any PSR7/17/18 compatible http client implementation. If you are ok with this changes I'm willing to continue working on that in next several weeks until changes are merged to the upstream.

from php-mattermost-driver.

both those changes sound great -- can you also update the documentation to use the Symfony HttpClient instead of guzzle? And if it's ready, submit a PR, since having guzzle and pimple just for this library seems a bit heavy. Thanks.

from php-mattermost-driver.

@tacman I've updated README & added #54

from php-mattermost-driver.