Giter VIP home page Giter VIP logo

Comments (4)

gnl avatar gnl commented on July 23, 2024 1

I just updated the README.

One final clarifying note on why this happened exactly – usually an older version of a dependency wouldn't automatically override a newer one when using tools.deps, however the older version of http-kit required by figwheel-sidecar uses the simple name http-kit while the newer one required by Portal uses the fully qualified name http-kit/http-kit, so these are effectively two separate artifacts on the classpath providing the same namespaces, which tends to result in chaos.

from playback.

gnl avatar gnl commented on July 23, 2024

My guess would be that Portal's reference to server/as-channel here doesn't resolve because something else on your classpath (possibly an older http-kit version) is providing the org.httpkit.server namespace and overriding Portal's dependency there.

Can you check for that and try to create a minimal repro, maybe with a very basic Hello World or template project that uses the same Shadow config, see if you can make it break and then start removing dependencies until it works and you find the culprit.

from playback.

DeadEarnest avatar DeadEarnest commented on July 23, 2024

I found the culprit for compilation error - [figwheel-sidecar "0.5.19"]. After removing it, exception goes away. Thanks for the advice!

I think you should add 2 points to the Quick Start guide:

1. org.clojure/clojurescript and org.clojure/clojure dependencies must be explicitly added to the project.

Without this, running a shadow-cljs project results in the following:
playback kind of works, but a Portal window still doesn't open up on REPL startup. I tried running (playback.core/open-portal!), and it returns:

:repl/exception!
;
; Execution error (TypeError) at (<cljs repl>:1).
; Cannot set properties of null (setting 'onunload')

2. Browsers might block Portal as a pop-up window.

I missed this at first, and thought that playback wasn't working properly.

from playback.

gnl avatar gnl commented on July 23, 2024

Glad it's working!

  1. org.clojure/clojurescript and org.clojure/clojure dependencies must be explicitly added to the project.

It's generally understood and implicitly assumed that people will manually add Clojure and ClojureScript as their most essential project dependencies; we don't automatically do this in libraries, because it risks overriding someone's chosen version in unpredictable ways. I will however add a note about the required Clojure version being 1.10+.

  1. Browsers might block Portal as a pop-up window.

That's a good point, I'll add a hint, thanks. I'll leave this issue open until I've updated the README.

from playback.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.