Comments (10)
I have to manually push it on Docker Hub, I will do it in the next few days. At the moment our Docker Hub account doesn't support automated builds but we have some alternatives we need to work on to support that.
from gns3-registry.
I have to manually push it on Docker Hub, I will do it in the next few days. At the moment our Docker Hub account doesn't support automated builds but we have some alternatives we need to work on to support that.
Oh, interesting.
Potentially you could use GitHub actions to build and push? This should appear to Docker Hub no different to a person pushing manually from the command line.
from gns3-registry.
Potentially you could use GitHub actions to build and push? This should appear to Docker Hub no different to a person pushing manually from the command line.
Yes we intend to use GitHub actions to build and push (only for the images that need to be updated). We actually have one issue opened for this: #468
from gns3-registry.
I have pushed the image: https://hub.docker.com/r/gns3/mikrotik-winbox
We will focus on #468 for the auto rebuild part. Thanks again and please don't hesitate to post if you see a problem.
from gns3-registry.
Potentially you could use GitHub actions to build and push? This should appear to Docker Hub no different to a person pushing manually from the command line.
Yes we intend to use GitHub actions to build and push (only for the images that need to be updated). We actually have one issue opened for this: #468
Hey there,
I see everything has been merged in to support this, but I have one major concern. You specified "only for images that need to be updated" and I am assuming this means an image will need to be updated in this repository for the process to even trigger let alone work?
This is concerning for my (and other) images which point to a third party container, as no changes will need to be made in this repo, yet upstream images will update and a new version must be pulled.
Thanks!
from gns3-registry.
I see everything has been merged in to support this, but I have one major concern. You specified "only for images that need to be updated" and I am assuming this means an image will need to be updated in this repository for the process to even trigger let alone work?
This is correct or we can also manually trigger the process.
This is concerning for my (and other) images which point to a third party container, as no changes will need to be made in this repo, yet upstream images will update and a new version must be pulled.
I am not sure how we could handle this. @b-ehlers do you have an idea or comment?
from gns3-registry.
The build tool checks for every docker image, defined in docker/docker_images, the following:
- image name included in the command line?
- files in the docker image directory within this repository have changed, for example by a git push
- image is missing in target docker repository
- base image has changed
All docker images, that meet any of these conditions, are rebuild.
The build tool is run on every git push, weekly and by a manual trigger.
So when you change your image alexhorner/winbox-dockerised
the next run of the build tool sees that the base image for docker/mikrotik-winbox
has changed and triggers a rebuild. In the worst case you have to wait for the next weekly run, so it can take up to 7 days.
from gns3-registry.
The build tool checks for every docker image, defined in docker/docker_images, the following:
* image name included in the command line? * files in the docker image directory within this repository have changed, for example by a git push * image is missing in target docker repository * base image has changed
All docker images, that meet any of these conditions, are rebuild.
The build tool is run on every git push, weekly and by a manual trigger.
So when you change your image
alexhorner/winbox-dockerised
the next run of the build tool sees that the base image fordocker/mikrotik-winbox
has changed and triggers a rebuild. In the worst case you have to wait for the next weekly run, so it can take up to 7 days.
7 days seems perfectly reasonable for most updates, and if there is a critical security vulnerability, I am sure an issue could be opened asking for a manual trigger?
from gns3-registry.
Sure, you can create an issue asking for a manual trigger to get an earlier update.
But an updated image doesn't mean, that the update gets to the user. Currently GNS3 loads an image the first time you put a device, based on that image, into a project. Afterwards GNS3 never updates that image. There is no way in the GNS3 GUI to ask for a docker image update. The user has to manually do a docker pull <image>
. I assume, that most users don't do that, so they stay with their outdated image. For details see issue #145.
from gns3-registry.
Sure, you can create an issue asking for a manual trigger to get an earlier update.
But an updated image doesn't mean, that the update gets to the user. Currently GNS3 loads an image the first time you put a device, based on that image, into a project. Afterwards GNS3 never updates that image. There is no way in the GNS3 GUI to ask for a docker image update. The user has to manually do a
docker pull <image>
. I assume, that most users don't do that, so they stay with their outdated image. For details see issue #145.
Yea, this is something I noticed too. I personally do pulls, but I do not expect the average user to even know a pull is possible, let alone keep on top of it. It would be good if there was a way for GNS3 to check for updates against the repository and alert the user to an available update and allow them to update either all, or a list. But yea, as you said, #145
from gns3-registry.
Related Issues (20)
- 3.2
- ubuntu-server.gns3a - Download site no longer available
- Outdated internet appliance generates strange error message
- Add Mikrotik WinBox Docker Container HOT 3
- Outdated ipterm appliance
- Support needed to publish docker images to both Docker Hub and ghcr.io? HOT 6
- ostinato-wireshark - Can't build Docker image HOT 1
- Status of docker images endhost, haproxy, network_automation_pycharm and openvswitch28 HOT 5
- Rebuild WinBox image HOT 8
- docker adosztal network automation is recommended not to be used in an exported project - especially on windows HOT 1
- Remove the opendaylight image on DockerHub HOT 1
- please do not quickly delete or rename dockers
- Retry on communication errors for docker build tool HOT 2
- Maintainer for vyos appliance wanted HOT 11
- Add "-cpu host" to all RedHat based appliances HOT 3
- Add vendor_logo_url in registry
- Purge Old Images from the appliances I Update? HOT 2
- Outdated Docker Images
- Schema 6 update in PR #732 missing in schema 7 and 8 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gns3-registry.