Recommended to use interface instead of struct in xxxManager about auth0 HOT 4 CLOSED

Hi @starsz, I find the proposal to adopt interfaces reasonable and your use case valid. Its a large undertaking however and a potentially backwards incompatible change (so a major version bump may be warranted).

Just to make sure you have explored the option, did you try to pass your own implementation of http.Client? Its not exactly the same, but you can mock the HTTP layer by providing a custom client.

from auth0.

@alexkappa do you have an example where injecting a mock http client has been done for auth0 when unit testing?

from auth0.

Just to make sure you have explored the option, did you try to pass your own implementation of http.Client? Its not exactly the same, but you can mock the HTTP layer by providing a custom client.

func WithClient(client *http.Client) ManagementOption {
	return func(m *Management) {
		m.http = client
	}
}

You can't pass an own implementation of http.Client either because the function uses the http.Client struct type instead of an interface around the Do method. Is there any other way to inject it?

from auth0.

Closed and cloned this issue to auth0/go-auth0#17

from auth0.