Comments (3)
cjslep
commented on June 2, 2024
2
Ack, will look into this over the next week (been unavailable the past week).
Thank you for the detailed report!
from activity.
cjslep
commented on June 2, 2024
Still on my radar to take a look at. :)
from activity.
cjslep
commented on June 2, 2024
Hi @sentriz !
First off: you were TOTALLY right! I am so sorry you had to go through the painful debugging process, and that it took me more than half a year to come around to look back at this. You did the heavy lifting and are right: it was a shadowing bug.
I was cleaning up the tests and decided to jump ahead to do the Accept tests for the federating case, and was able to prove with unit tests that the shadowing was indeed the problem.
The latest commit c994dc3 introduces both the bugfix and the suite of tests for the Accept handling!
Thanks so much for providing all the documentation that you did, and for correctly identifying the root cause!
from activity.
Related Issues (20)
- Aggressive deserialization into PublicKey HOT 4
- Non-functional properties multiple "Append" => 1 element HOT 3
- Destroy copy/pasted code
- Interested in contributing HOT 4
- /pub/util.go: wrapInCreate: nil pointer dereference HOT 3
- Docs don't specify package name for some types HOT 1
- ActivityStreamsOrderedProperty isn't array with only one item HOT 1
- Clarification: What should pub.Database.Lock do if a lock is already held? HOT 1
- Clarification: can pub.Database.GetInbox and pub.Database.GetOutbox return an empty collection? HOT 1
- go-fed down HOT 1
- requestId supports only https => handler dereferences nil HOT 2
- Context propagation when nil context returns from AuthenticateGetOutbox/AuthenticateGetInbox
- Use example.org instead of example.dev HOT 1
- Creating non-standard properties on existing vocabulary + creating non-standard vocabulary HOT 2
- A single object within the attachment property does not serialize as an array HOT 3
- Avoid reliance on a dead JSON-LD namespace link HOT 3
- Broken tests are causing GitHub Actions to fail
- expired certificate for go-fed.org/
- go-fed.org is down HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from activity.