Giter VIP home page Giter VIP logo

Comments (1)

alexcesaro avatar alexcesaro commented on July 28, 2024

Until very recently Gomail used smtp.SendMail from the standard library to send emails and that function takes msg []byte as an argument. So the whole email needed to be in memory anyway.

Now that Gomail use a custom function to send emails, the email could be streamed to the SMTP server. So it is true that the content field of File could now be an io.Reader instead of []byte.

However doing that change will break backward compatibility because the signatures of File, OpenFile, CreateFile and SetSendMail will have to be updated.

Since this is not a big issue (email attachments are supposed to be relatively small) I will wait for other breaking changes before fixing this issue and bumping the version number.

from gomail.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.