codec/jsonrpc: Handle missing result key gracefully about go-micro HOT 10 CLOSED

That is basically invalid json-rpc. It should probably not panic but you should also not be sending that.

from go-micro.

It's unlikely that I'll add panic handling in the codec itself. I think that's the wrong place for it. It should ideally be in the client.

from go-micro.

I don’t care where and how the check is done, I just don’t want my API gateway to crash/panic if a service sends malformed json-rpc responses.

from go-micro.

Helpful, cheers. I don't think anyone wants the gateway to panic. PRs always welcome.

from go-micro.

Here's a graceful catch all that should resolve. 02481c4

Close issue if satisfied. Thanks.

from go-micro.

What’s wrong with just checking result is not nil before dereferencing?

master...thcyron:check-result

from go-micro.

Also worth doing. recover() just covers anything that will cause it to bomb out.

from go-micro.

Yep. I prefer to prevent it from panicking in the first place, but maybe we should do just both.

from go-micro.

0190b1a

Done and done.

from go-micro.

👍

from go-micro.