Giter VIP home page Giter VIP logo

Comments (3)

Sergei8888 avatar Sergei8888 commented on May 27, 2024 1

Fix needed

from ozzo-validation.

anjolaoluwaakindipe avatar anjolaoluwaakindipe commented on May 27, 2024

@tranlongan051020 After looking into this, I noticed that the Min and Max methods of the library skips validation checks if the value being validated is zero. This could be a design decision from the maintainers, but I'm not too sure. I cloned the repository and noticed that the fix for your scenario would be to remove the IsEmpty() function from the ThresholdRule Validation method. I also agree that validating zero within a min and max threshold should be treated like any other number

Original Code (minmax.go)

...
func (r ThresholdRule) Validate(value interface{}) error {
	value, isNil := Indirect(value)
	
	if isNil || IsEmpty(value) { // <---- What's causing the problem
		return nil
	}

	rv := reflect.ValueOf(r.threshold)
	switch rv.Kind() {
	case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
		v, err := ToInt(value)
		if err != nil {
			return err
		}
		if r.compareInt(rv.Int(), v) {
			return nil
		}

	case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr:
		v, err := ToUint(value)
		if err != nil {
			return err
		}
		if r.compareUint(rv.Uint(), v) {
			return nil
		}

	...
}
...

Proposed way to solve it

...
func (r ThresholdRule) Validate(value interface{}) error {
	value, isNil := Indirect(value)
	
	if isNil { // <--- remove check
		return nil
	}

	rv := reflect.ValueOf(r.threshold)
	switch rv.Kind() {
	case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
		v, err := ToInt(value)
		if err != nil {
			return err
		}
		if r.compareInt(rv.Int(), v) {
			return nil
		}

	case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr:
		v, err := ToUint(value)
		if err != nil {
			return err
		}
		if r.compareUint(rv.Uint(), v) {
			return nil
		}

...
}
...

What isEmpty() is doing

func IsEmpty(value interface{}) bool {
	v := reflect.ValueOf(value)
	switch v.Kind() {
	case reflect.String, reflect.Array, reflect.Map, reflect.Slice:
		return v.Len() == 0
	case reflect.Bool:
		return !v.Bool()
	case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
		return v.Int() == 0
	case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr:
		return v.Uint() == 0
	case reflect.Float32, reflect.Float64:
		return v.Float() == 0
	case reflect.Invalid:
		return true
	case reflect.Interface, reflect.Ptr:
		if v.IsNil() {
			return true
		}
		return IsEmpty(v.Elem().Interface())
	case reflect.Struct:
		v, ok := value.(time.Time)
		if ok && v.IsZero() {
			return true
		}
	}

	return false
}

from ozzo-validation.

Xyedo avatar Xyedo commented on May 27, 2024

i think what the maintainer meant is if its empty (default value or nil), then its optional, so it skip the validation, so we have to use validation.Required for default value or nil, or if you want to use only if the pointer is not nil, you can use validation.NotNil

func (u User) Validate() error {
	return validation.ValidateStruct(&u,
		validation.Field(&u.Number1, validation.Required, validation.Max(-1)),
		validation.Field(&u.Number2, validation.Required, validation.Min(1)),
		validation.Field(&u.Number3, validation.NotNil, validation.Max(-1)),
		validation.Field(&u.Number4, validation.NotNil, validation.Min(1)),
	)
}

and if you run the code, youll get

Validation error: Number1: cannot be blank; Number2: cannot be blank.

from ozzo-validation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.