Giter VIP home page Giter VIP logo

Comments (8)

ncw avatar ncw commented on June 12, 2024 3

Probably the simplest thing is to go with what goreleaser provides us with:

So make a version.go file with this in

package main

var (
	version = "dev"
	commit  = "none"
	date    = "unknown"
)

Then the release builds will have the correct version, commit and date in. The dev builds will have "dev" "none" and "unknown".

Python 3.5.3 (fdd60ed87e941677e8ea11acf9f1819466521bf2, Apr 26 2018, 01:23:42)
[PyPy 6.0.0 with GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)] on darwin
Type "help", "copyright", "credits" or "license" for more information.

This provides most of what we need here.

Note that we should show the go runtime version os and arch too as that is really important debugging info.

	fmt.Printf("- os/arch: %s/%s\n", runtime.GOOS, runtime.GOARCH)
	fmt.Printf("- go version: %s\n", runtime.Version())

from gpython.

corona10 avatar corona10 commented on June 12, 2024

@ncw @sbinet
What do you think about displaying build information?
And it will be able to implement it without 3rd party library?

from gpython.

corona10 avatar corona10 commented on June 12, 2024

Looks like we can inject the commit log by using ldflag during build time.

from gpython.

ncw avatar ncw commented on June 12, 2024

This is slightly awkward to do as it can't be done using the standard go build (at least I haven't figured out how!)

I do this in rclone and I have a Makefile which does the build

https://github.com/ncw/rclone/blob/39eac7a7658494a5404dfd75c80f0be3e6d222b2/Makefile#L35

If you build rclone not via the Makefile you get a v1.45-DEV build

I'm pretty sure you can do this with go-releaser which we use to build the release binaries.

I had a chat with the debian maintainer about rclone and this issue, and his thoughts were that the program should build using the normal go tools to make the correct version number at the releases. Which kind of implies when we make a release, we should check in the build description. That is what I do in rclone anyway, but the Makefile adds a git ID for non release builds.

from gpython.

corona10 avatar corona10 commented on June 12, 2024

@ncw
Yeah looks like rclone way is the best way from now on.
@sbinet Do you have any ideas?

from gpython.

sbinet avatar sbinet commented on June 12, 2024

not sure there's anything else than what rclone does.
go generate isn't run by default, so that's out.

if we wanted to also support Windows, we could perhaps use mage, but that's another tool to install...
so, yeah, the rclone way is fine by me.

from gpython.

corona10 avatar corona10 commented on June 12, 2024

@ncw LGTM

from gpython.

corona10 avatar corona10 commented on June 12, 2024

Looks like a good first issue for a newbie of this project.

  • Display build information

from gpython.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.