In standard python <div class="highlight highlight-source-python notranslate posit

Implementing __iter__ for dict is very useful. <p

suggest <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-

fixed w/ <a class="issue-link js-issue-link" data-error-text="Failed to load title" da

Checking dict keys fails about gpython HOT 3 CLOSED

go-python commented on June 12, 2024

Checking dict keys fails

from gpython.

Comments (3)

ncw commented on June 12, 2024

Implementing __iter__ for dict is very useful.

However for in to be efficient we should be implementing __contains__

gpython/py/sequence.go

Lines 121 to 147 in 61059b4

 // SequenceContains returns True if obj is in seq 

 func SequenceContains(seq, obj Object) (found bool, err error) { 

 if I, ok := seq.(I__contains__); ok { 

 result, err := I.M__contains__(obj) 

 if err != nil { 

 return false, err 

 } 

 return result == True, nil 

 } else if result, ok, err := TypeCall1(seq, "__contains__", obj); ok { 

 if err != nil { 

 return false, err 

 } 

 return result == True, nil 

 } 

 var loopErr error 

 err = Iterate(seq, func(item Object) bool { 

 var eq Object 

 eq, loopErr = Eq(item, obj) 

 if loopErr != nil { 

 return true 

 } 

 if eq == True { 

 found = true 

 return true 

 } 

 return false 

 })

from gpython.

drew-512 commented on June 12, 2024

suggest @sbinet close -- addressed in #65

from gpython.

sbinet commented on June 12, 2024

fixed w/ #65 .

from gpython.

Checking dict keys fails about gpython HOT 3 CLOSED

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// SequenceContains returns True if obj is in seq
	func SequenceContains(seq, obj Object) (found bool, err error) {
	if I, ok := seq.(I__contains__); ok {
	result, err := I.M__contains__(obj)
	if err != nil {
	return false, err
	}
	return result == True, nil
	} else if result, ok, err := TypeCall1(seq, "__contains__", obj); ok {
	if err != nil {
	return false, err
	}
	return result == True, nil
	}
	var loopErr error
	err = Iterate(seq, func(item Object) bool {
	var eq Object
	eq, loopErr = Eq(item, obj)
	if loopErr != nil {
	return true
	}
	if eq == True {
	found = true
	return true
	}
	return false
	})