Comments (7)
you're right.
from zmq4.
May be as simple as removing the check and return at
Line 236 in 59e906c
Also, thanks so much for doing this, it's saving me a lot of pain trying to build my app for other architectures. No CGO is a win!
from zmq4.
This is a better reference: https://rfc.zeromq.org/spec/23/#socket-semantics
from zmq4.
Hi!
At the moment the user facing .Dial is synchronous. This should be kept that way.
The spec talks about "reconnect", which in my view is something different from the initial connect.
I would opt for the following:
- leave the initial connect synchronous to get some errors back (network unreachable, unknown host etc.)
- implement a reconnect method used after there has been a successful first connection
While implementing 1. I'd like to add a context.Context to the .Dial methods or add a .DialContext method.
Cheers
Guido
from zmq4.
I think that the numbers of retries should be configurable, if the user sets it to infinite (could be -1 or so) then the behavior will be very similar to the libzmq implementation, while still being synchronous
from zmq4.
sure, why not.
do you want to try your hand at a PR?
from zmq4.
do you want to try your hand at a PR?
yes, I think I could. Not sure when I will have time for it, though
from zmq4.
Related Issues (20)
- pub sub err , when close the server the client get error and close HOT 1
- Go channel interface
- meta: consider setting up an OpenCollective account HOT 1
- router node restart recv block
- SUB socket SetOption must come after Dial, goczmq/pebbe don't have such limitation HOT 1
- Pull socket can not be properly closed, if no clients ever connected HOT 3
- REP socket races on client connection
- no reconnect possible when using `zmq4.NewPub` with `socket.Dial` HOT 4
- Why is go-zeromq/zmq4 not needing libzmq on windows? HOT 1
- socket accept a new connection, will send and read the greet message,if client always not response with greet message,other client can't connect to server
- Dead lock, how to fix? HOT 2
- github.com/pebbe/zmq2 (2.2.0) sub socket cannot connect to github.com/go-zeromq/zmq4 pub socket HOT 2
- Can't get a proxy to work (XSUB/XPUB)
- subSocket.Topics() is not accessible
- meta: new ZeroMQ/C++ license HOT 7
- Send timeout does not works HOT 4
- Deadlock detected by TestConnReaperDeadlock HOT 2
- PUB / SUB sockets
- PUB/SUB UDP socket HOT 1
- The connReaper goroutine may leak HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zmq4.