Giter VIP home page Giter VIP logo

Comments (5)

RDoll-Repo avatar RDoll-Repo commented on June 5, 2024 1

As for the golden seeds contribution, I could see it being a tab like how graces are but I think it would be tough to describe their positions. Looking at the wiki sometimes they have map links, sometimes they just have video links for locations, sometimes it's like a paragraph to guide people to where they are. What did you have planned for this?

My thought was to group them by region as you do with the bosses, then I would briefly describe an approximate location using nearby landmarks. A somewhat terse description of locations should be possible for most of them. If there are any particularly obtuse seeds, I could perhaps link to a video as the wiki does, but given that the user is actively exploring the area, they should be able to narrow down the location of the seed in question- at least enough to verify which seed they've just collected so they don't get it confused with other seeds.

...with Typescript/React, I knew I wanted to try my hand at contributing since I recently started using these things for work.

I'm not sure how much experience you'll get from this contribution to be honest. If you were looking for gaining more experience with these languages. Most of the additions to this project are pretty much just modifying json so you won't be gaining any experience with the technologies you are looking for unfortunately.

The motivation for me wasn't necessarily experience with the technologies in this project, but to get my feet wet with contributing to projects outside of my own work, or things I do for my job. I had a cursory look at the code before I opened the issue so I knew about what I was in for as far as implementing this. This is totally fine with me

If that's fine with you, you can check out 6b1c829 to see how seeds would need to be setup. This commit basically sets up a whole new tab with information. It will be a good base to get started.

Thanks for the pointer. I'll go ahead and get started then

from elden-ring-checklist.

Gobluebro avatar Gobluebro commented on June 5, 2024

Hello welcome. Thank you for the kind words.

I wanted to ask permission to clone the project

There is no need to ask for permission. This project is open sourced to the public. Anyone may clone this and do what they wish with this project.

As for the golden seeds contribution, I could see it being a tab like how graces are but I think it would be tough to describe their positions. Looking at the wiki sometimes they have map links, sometimes they just have video links for locations, sometimes it's like a paragraph to guide people to where they are. What did you have planned for this?

...with Typescript/React, I knew I wanted to try my hand at contributing since I recently started using these things for work.

I'm not sure how much experience you'll get from this contribution to be honest. If you were looking for gaining more experience with these languages. Most of the additions to this project are pretty much just modifying json so you won't be gaining any experience with the technologies you are looking for unfortunately.

If that's fine with you, you can check out 6b1c829 to see how seeds would need to be setup. This commit basically sets up a whole new tab with information. It will be a good base to get started.

from elden-ring-checklist.

Gobluebro avatar Gobluebro commented on June 5, 2024

A somewhat terse description of locations should be possible for most of them.

That sounds fine to me. It follows the original intention of this project, which is to not really be a guide for players since there is just so many guides out there already doing this. It's mostly just for keeping track of where players have progressed so far.

from elden-ring-checklist.

RDoll-Repo avatar RDoll-Repo commented on June 5, 2024

@Gobluebro, thanks for your patience, been quite busy with work. I have opened a PR: #39

from elden-ring-checklist.

Gobluebro avatar Gobluebro commented on June 5, 2024

Pr has been merged. Thank you for the help

from elden-ring-checklist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.