Comments (1)
That might be a very bad idea.
I'm no MySQL engineer, so I can't say for sure this is a reasonable thing to do. I assume it is, because my read of SetupTest() is that it's dropping all data from the database, so there should be no data left to be orphaned, but... I don't know very MySQL well, so I don't know what corner cases (or not-so-corner cases) that setting might impact.
Right now, I can't find a better option, even after using MySQL for years.
I'm not sure if it would be correct to modify TruncateAll() in that way.
Again I assume it would be, but I'm not familiar enough with the consumers of Pop to know if that would lead to surprising behavior. If foreign key constraints are set, truncations should fail. Would changing this function cause logic that should fail, to not fail? Would there be a clean way to add an argument or contextual setting to TruncateAll() that would let us control that behavior? Are there any uses of TruncateAll outside of SetupTest() for such a change to affect, anyway?
To answer that question, we have to check the other DB behavior for pop supported dialects. If the other allow to truncate all the tables, even with foreign keys, we should do it.
from pop.
Related Issues (20)
- feature proposal: add support to oracle DB HOT 1
- bug: transaction panic recovery swallows panic message HOT 3
- feature: log transaction/connection ID to track SQL executions for a request
- feature: Read/Write routing to different endpoints HOT 2
- feature: improve performance if the element of the Value of *Model does not implement the AfterFindable interface. HOT 4
- bug: DB connection locks up under load calling DB.Create(), regression in 6.1.0 vs 6.0.8 HOT 8
- feature: parallelize association loading HOT 2
- process: update supported database versions
- bug: sqlite3 testing on Windows + go 1.17 failing sometimes HOT 3
- bug: incorrect error handling
- Need a way to update stale pop connecton configs before pop reconnections a failed connectionfeature: HOT 6
- feature: upgrade jackc/pgx to v5 HOT 2
- feature: Dialect for Cassandra HOT 3
- feature: DB connection timeout HOT 2
- bug: "cannot parse UUID" on models.DB.Create HOT 1
- feature: context plumbing HOT 2
- bug: SQL connection leak when using EagerPreload HOT 4
- Slack Channel Not Working HOT 3
- is this project dead? HOT 5
- bug: Need to wrap error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pop.