Generating model with SQL files instead of Fizz files about pop HOT 6 CLOSED

A PR would definitely be welcome.

from pop.

Ok great, I will try to see how it works and if I have enough time maybe work on it.

Any infos or guidelines are welcome !

from pop.

Off the top of my head I would suggestion using the fizz package to build the sql for the forest platform, and then dump that into the generated sql file.

from pop.

Indeed, using the fizz package works pretty well, but I need to use a *pop.Connection in order to retrieve the correct Dialect and generate the good sql file depending the environment.

I saw that there is a function getConn() in the github.com/gobuffalo/pop/soda/cmd package.
So far, I passed the function as an argument into a constructor which return the ModelCmd.

Here's a snippet of this :

package generate 

...
type getConnection func() *pop.Connection

func NewModelCmd(f getConnection) *cobra.Command {
	connection = f()
	return ModelCmd
}

But it seems very ugly to do so, maybe any of you has an idea about how could I do this ?

from pop.

I definitely wouldn't do that. :)

All the getConn function does is check if a connection is in the map. I wouldn't go that far. You can do something as simple as:

eee, err := cmd.Flags().GetString("env")
if err != nil {
	return errors.WithStack(err)
}
db, err := pop.Connect(eee)

This is a persistent flag on the root command for the environment string. you can get access to that inside whatever sub-command you're in.

from pop.

I close this issue since the PR #63 was merged

from pop.