Giter VIP home page Giter VIP logo

Comments (6)

u007 avatar u007 commented on July 21, 2024

btw, im quite trouble by the direction of this project, can i have words on all merge request before merging?

from pop.

markbates avatar markbates commented on July 21, 2024

Can you provide steps to reproduce?

In terms of reviewing PRs everyone is allowed to jump in PRs, please do so. If you have opinions and suggestions, please make them heard.

In what particular ways are you troubled by the direction? Can you provide more clarity?

from pop.

u007 avatar u007 commented on July 21, 2024

im concern about naming, and also how rawquery used to work with eagerload initially, and later on it wasnt anymore

from pop.

stanislas-m avatar stanislas-m commented on July 21, 2024

@u007
As I said on other issues, I think RawQuery and others features are two separate worlds. This means it's not supposed to work with features like Eager loading, or Count, because it means we'll have to rewrite the raw query.

That's my point of view, and I think the main problem here is about having a bug which transforms to a feature. So to begin with, we should write a specification about how it should work.

If you disagree, I'm all ears. :) Maybe it's just about providing a missing feature, so you don't need to rely on a workaround.

from pop.

u007 avatar u007 commented on July 21, 2024

hi @stanislas-m sometimes we need custom query to join tables for query to populate result into a struct (not the original query) and it should be able to detect other tables that it is linked from the original struct.
i think this is a norm in rails and it works.
perhaps we need a detector to ensure its a select raw query before activating count...
and as for eager should work, because its dependent on struct.

i wanted to help, but which file should i start my dive from?

from pop.

u007 avatar u007 commented on July 21, 2024

i realized it is working with the latest master branch, did someone fixed it?
ive also added pagination support with rawquery

#98

from pop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.