stack overflow when processing schema importing multiple files about xsd2go HOT 5 CLOSED

I am not entirely sure, but this could be an easy fix. At least a very brief look at the code suggests that.

We cache XSD files we already read

and few lines below we load all the imports of the current file:

Potentially we just need to wrap this si.load() call with an if that will ensure not to load schemas that have been already loaded.

Not sure however, if the compilation of the xsd schemas won't fail later on. Would you like to explore this and propose a patch?

Thanks!

from xsd2go.

I think the sub-schemas are then missing in the workspace, leading to missing types. I will try to remove the recursion and collect all imports - split parse and compile.

from xsd2go.

Hello @dratasich,

Your analysis seems to be correct. There is circular dependency in these XSD files and current codebase does not account for such case.

from xsd2go.

Cool, thanks @isimluk for pointing out the responsible code parts.

With

	for idx := range schema.Imports {
		childXsdPath := filepath.Join(dir, schema.Imports[idx].SchemaLocation)
		_, found := ws.Cache[childXsdPath]
		if found {
			continue
		}
		if err := schema.Imports[idx].load(ws, dir); err != nil {
			return nil, err
		}
	}

I could avoid the stack overflow - thanks again!
Unfortunately I still have an error, so I have to check if its a model error (my guess) or if I miss a type due to this change.

./gocomply_xsd2go convert ~/repos/parkandride-api/gen/3.4/DATEXII_3_LocationReferencing.xsd datex3 .
Processing '/home/denise/repos/parkandride-api/gen/3.4/DATEXII_3_LocationReferencing.xsd'
	Parsing: /home/denise/repos/parkandride-api/gen/3.4/DATEXII_3_LocationReferencing.xsd
	Parsing: /home/denise/repos/parkandride-api/gen/3.4/DATEXII_3_LocationReferencing.xsd
	Parsing: /home/denise/repos/parkandride-api/gen/3.4/DATEXII_3_Common.xsd
panic: Cannot resolve type reference: com:Boolean

from xsd2go.

I succeeded to generate Go code with xgen -l Go (and Java code with jaxb with a bindings.xml / config).

To cope with circular imports I think it would need a bigger restructuring/rewriting in the xsd/workspace.go file.
So I will close this issue here.

from xsd2go.