Web build fails on Emscripten 3.1.58 about godot HOT 4 CLOSED

The regression comes from 3.1.58 itself, I built successfully with 3.1.57.

This change sounds pretty relevant:

Multi-threaded builds no depend on a separate .worker.js file. This saves on code size and network requests. In order to make this change go smoothly, without breaking build systems that expect a worker.js, emscripten will generate an empty .worker.js to give folks time to transition their deployment scripts. In -sSTRICT mode, this empty file will not be generated. (#21701)

https://github.com/emscripten-core/emscripten/blob/main/ChangeLog.md#3158---042324

@adamscott @Faless

from godot.

Multi-threaded builds no depend on a separate .worker.js file. This saves on code size and network requests. In order to make this change go smoothly, without breaking build systems that expect a worker.js, emscripten will generate an empty .worker.js to give folks time to transition their deployment scripts. In -sSTRICT mode, this empty file will not be generated. (#21701)

While this change isn't the reason for the build failure (see #91202) (EDIT: The mentioned change does indeed seem to be the culprit), it's something we need to track, and IMO a very welcome change from upstream since it makes load time faster (one less fetch).

I wonder if/when we could bump to 3.1.58 as the minimum version and do some cleanup in our threaded load/export paths.

from godot.

Seems like the issue is caused by a bug upstream fixed via emscripten-core/emscripten#21830 (which will be in 3.1.59).

from godot.

Thanks for checking! This is a wontfix then, as there's little point trying to workaround a bug only present in one release.

We can still fix the warnings as you've started doing though.

There's also this one that might be worth a look:

wasm-ld: warning: function signature mismatch: unztell
>>> defined as (i32) -> i64 in core/libcore.web.editor.wasm32.a(file_access_zip.web.editor.wasm32.o)
>>> defined as (i32) -> i32 in core/libcore.web.editor.wasm32.a(unzip.web.editor.wasm32.o)

from godot.