Giter VIP home page Giter VIP logo

Comments (7)

Calinou avatar Calinou commented on May 30, 2024 1

This is likely a precision issue in the mesh skinning shader, which could be alleviated by adding highp qualifiers in the right location (at a performance cost). I'm surprised this occurs on non-Qualcomm GPUs though; usually, it's the opposite.

from godot.

dsyze avatar dsyze commented on May 30, 2024

This is likely a precision issue in the mesh skinning shader, which could be alleviated by adding highp qualifiers in the right location (at a performance cost). I'm surprised this occurs on non-Qualcomm GPUs though; usually, it's the opposite.

Thanks, can you tell me more details on how to adding highp qualifiers in the right location ?

from godot.

clayjohn avatar clayjohn commented on May 30, 2024

@dsyze In this file https://github.com/godotengine/godot/blob/master/drivers/gles3/shaders/skeleton.glsl You would replace all the places where it says mediump with highp. And then below, in the body of the shader, when a new variable is defined you would add highp as well (e.g. highp vec3 instead of just vec3)

from godot.

dsyze avatar dsyze commented on May 30, 2024

@dsyze In this file https://github.com/godotengine/godot/blob/master/drivers/gles3/shaders/skeleton.glsl You would replace all the places where it says mediump with highp. And then below, in the body of the shader, when a new variable is defined you would add highp as well (e.g. highp vec3 instead of just vec3)

Thank you, sir! I will try.

from godot.

dsyze avatar dsyze commented on May 30, 2024

@dsyze In this file https://github.com/godotengine/godot/blob/master/drivers/gles3/shaders/skeleton.glsl You would replace all the places where it says mediump with highp. And then below, in the body of the shader, when a new variable is defined you would add highp as well (e.g. highp vec3 instead of just vec3)

Unfortunately, the issue persists even after using the recompiled editor and the Android export template.

from godot.

clayjohn avatar clayjohn commented on May 30, 2024

@dsyze In this file https://github.com/godotengine/godot/blob/master/drivers/gles3/shaders/skeleton.glsl You would replace all the places where it says mediump with highp. And then below, in the body of the shader, when a new variable is defined you would add highp as well (e.g. highp vec3 instead of just vec3)

Unfortunately, the issue persists even after using the recompiled editor and the Android export template.

Could you share the updated version of the skeleton.glsl file you used so I can verify you changed all the necessary places?

Also, to confirm, you recompiled the editor and the android export template right?

from godot.

dsyze avatar dsyze commented on May 30, 2024

@dsyze In this file https://github.com/godotengine/godot/blob/master/drivers/gles3/shaders/skeleton.glsl You would replace all the places where it says mediump with highp. And then below, in the body of the shader, when a new variable is defined you would add highp as well (e.g. highp vec3 instead of just vec3)

Unfortunately, the issue persists even after using the recompiled editor and the Android export template.

Could you share the updated version of the skeleton.glsl file you used so I can verify you changed all the necessary places?

Also, to confirm, you recompiled the editor and the android export template right?

skeleton.zip
Thanks a lot.

from godot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.