Giter VIP home page Giter VIP logo

Comments (2)

OctagonalHexy avatar OctagonalHexy commented on May 30, 2024

After looking at the ways Godot uses add_undo_redo_inspector_hook_callback() internally, I can confirm that none of the internal uses of this function should be effected by this fix given that multi node editing currently does not apply to Resources like Material3D, and TileSet. #91843

from godot.

OctagonalHexy avatar OctagonalHexy commented on May 30, 2024

After thinking on this further, I think making this return A callback for each edit in A multi node edit would make this callback fall out of sync with how UndoRedo is assigned when multi editing nodes which feels wrong based on its description in the docs.

Having MultiNodeEdit itself return A single callback with info that can be used to query the changes made would be both more in line with the single do\undo added to UndoRedoManager by MultiNodeEdit when editing multiple nodes, and would require specific handling in plugins to be able to react to MultiNodeEdits theoretically ensuring that no uses of add_undo_redo_inspector_hook_callback() are effected by these changes at all.

I think this is the least impactful way to fix the inability to react to editing multiple nodes in the inspector the way, "Hooks a callback into the undo/redo action creation when a property is modified in the inspector." implies in the docs.

from godot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.