Comments (2)
After looking at the ways Godot uses add_undo_redo_inspector_hook_callback() internally, I can confirm that none of the internal uses of this function should be effected by this fix given that multi node editing currently does not apply to Resources like Material3D, and TileSet. #91843
from godot.
After thinking on this further, I think making this return A callback for each edit in A multi node edit would make this callback fall out of sync with how UndoRedo is assigned when multi editing nodes which feels wrong based on its description in the docs.
Having MultiNodeEdit itself return A single callback with info that can be used to query the changes made would be both more in line with the single do\undo added to UndoRedoManager by MultiNodeEdit when editing multiple nodes, and would require specific handling in plugins to be able to react to MultiNodeEdits theoretically ensuring that no uses of add_undo_redo_inspector_hook_callback() are effected by these changes at all.
I think this is the least impactful way to fix the inability to react to editing multiple nodes in the inspector the way, "Hooks a callback into the undo/redo action creation when a property is modified in the inspector." implies in the docs.
from godot.
Related Issues (20)
- Duplicate input events on TabContainer _gui_input() and _input()
- Godot 3.6 Beta 5 does not bake 3D models via merge_meshes HOT 1
- [4.3] Editor renders pixelated on macOS + external display HOT 2
- SSR and SSAO seem to stop working when transparent background is enabled. HOT 1
- ContextMenu `Copy Error` is off in `MSBuild` Panel
- Godot C# exports crash on launch if solution/project/assembly names don't match HOT 2
- [Source Generator] Unable to disable multiple source generators using `GodotDisabledSourceGenerators` property HOT 1
- 2D Runtime-Baked Navigation Mesh Not Working with Agent HOT 5
- Polygon is distorted in NavigationObstacle2D HOT 9
- Physics interpolation breaks GPUParticles2D movement HOT 2
- Changing name of script after using it in `preload()` generates "Could not resolve script" error, recoverable only by reloading project HOT 1
- [GDScript] Conflict between Variable Name and Type in Unresolvable Scope HOT 3
- AnimatedSprite2D default animation changes when I edit an animation HOT 2
- 4.3.dev - Problems with launching Godot/launching projects in a compositor with Xwayland disabled HOT 3
- Importing a jpg image may result in wrong colors. HOT 7
- Editor crashes while trying to generate docs for a GDExtension class HOT 3
- Fog Sky Affect Not Working in Compatibility Renderer HOT 1
- Godot 4.3 Pull Request 90601 broke addon compatibility and segfaults HOT 3
- GDScript `STANDALONE_EXPRESSION` warning should not apply for `preload` (due to static initializers) HOT 1
- OpenXR: Unable to update the swapchain [ XR_ERROR_HANDLE_INVALID ] HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from godot.