Comments (5)
This should be reported in another issue, but you could check out in test/thetest.proto
message NidRepCustom {
repeated bytes Id = 1 [(gogoproto.customtype) = "Uuid", (gogoproto.nullable) = false];
repeated bytes Value = 2 [(gogoproto.customtype) = "github.com/gogo/protobuf/test/custom.Uint128", (gogoproto.nullable) = false];
}
The equal method does the following
func (uuid Uuid) Equal(other Uuid) bool {
return bytes.Equal(uuid[0:], other[0:])
}
Does this help?
from protobuf.
I've run into problems with proto.Equal()
and a proto where we use gogoproto.customtype
for a bytes
field. I hope this is the right place to report.
This is the proto:
https://github.com/cockroachdb/cockroach/blob/befea82/pkg/roachpb/metadata.proto#L73
And the error is:
panic: interface conversion: interface {} is roachpb.RKey, not []uint8
It's because of this special handling of bytes
fields in proto.Equal
:
https://github.com/golang/protobuf/blob/ef00c02/proto/equal.go#L218
Any ideas for a work-around?
from protobuf.
You are welcome to contribute a fix with a test, but an easier fix might be to just generate equal methods.
Generating equal methods can be done in two ways:
- Using the gogoprotobuf equal extension https://godoc.org/github.com/gogo/protobuf/plugin/equal
- Using my new project https://github.com/awalterschulze/goderive
from protobuf.
Thanks! The equal extension looks good! But I've run into another issue with it, reported in #283.
from protobuf.
When using a customtype that is an array proto.Equal does not work, outputs log message proto: don't know how to compare ...
.
The switch
at
Line 151 in 5628607
reflect.Array
case which explains why this does not work.
Before digging into the code I also tried defining Equal
func for my customtype since I was expecting that it may be used, but proto.Equal
does not appear to try to use it at all.
from protobuf.
Related Issues (20)
- Enum filling with negative numbers will report an error, is it the Enum that does not support negative numbers?
- License question
- protoreflect
- Vulnerability?
- Panic: invalid Go type HOT 3
- github.com/gogo/protobuf is not installed
- Improper Input Validation in GoGo Protobuf HOT 1
- string time and duration
- oom
- Panic: reflect: Elem of invalid type HOT 1
- How to customize the name of an enumeration value, using the extension `enumvalue_customname ` seems unable to complete.
- m argument not work
- Call command.Generate(req *plugin.CodeGeneratorRequest) twice could cause bug.
- BUG: protoc-gen-gogofast not generate trailing comments
- How to generate parameter "description" in message of proto3 HOT 1
- proto: protect field access with lock to avoid possible data race
- proto: protect field access with lock to avoid possible data race
- Release v1.3.3 - Please please please create it pointing to v1.3.2
- Unsafe type assertion
- Generate a custom function. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protobuf.