Comments (4)
@btamadio Thanks for pointing this out. Can you raise a PR for the same, will have a look
from heimdall.
Here's a snippet illustrating the issue. With min=1second, max=8 seconds, and exp. factor=2,
I would expect the backoff times to be 1, 2, 4, 8, 8 seconds:
func main() {
fmt.Println("testing constant backoff ...")
s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(500)
}))
defer s.Close()
cli := httpclient.NewClient(
httpclient.WithRetryCount(5),
httpclient.WithHTTPClient(s.Client()),
httpclient.WithRetrier(
heimdall.NewRetrier(
heimdall.NewExponentialBackoff(
1*time.Second,
8*time.Second,
2,
2*time.Millisecond,
),
),
),
)
cli.AddPlugin(plugins.NewRequestLogger(os.Stdout, os.Stderr))
_, _ = cli.Get(s.URL, nil)
}
Timestamps show this is not happening:
21/May/2020 11:18:37 GET http://127.0.0.1:51397 500 [0ms]
21/May/2020 11:18:37 GET http://127.0.0.1:51397 500 [0ms]
21/May/2020 11:18:38 GET http://127.0.0.1:51397 500 [0ms]
21/May/2020 11:18:39 GET http://127.0.0.1:51397 500 [0ms]
21/May/2020 11:18:40 GET http://127.0.0.1:51397 500 [1ms]
21/May/2020 11:18:41 GET http://127.0.0.1:51397 500 [0ms]
from heimdall.
@btamadio Thanks for the PR. Have added a few comments
from heimdall.
@btamadio Thanks for the PR. Have added a few comments
Took a look but couldn't find any comments on the PR.
from heimdall.
Related Issues (20)
- HystrixTimeout vs HTTPTimeout HOT 3
- No way to parse proxies / http transport with hystrix client? HOT 1
- How can I set verify=false when call to HTTPS endpoint? HOT 2
- Support single connection for multiple request HOT 3
- Add singleflight in client
- 'httpclient' forcing close connection
- Sending data-urlencode in Get request
- Dependency of gojek is pointing to gojektech HOT 1
- unable to install? HOT 3
- Gaps of "idle?" time when using a retrier extend the response time of my app HOT 1
- Requests are being hardcoded to get close after response HOT 1
- Unclear documentation for hystrix client options HOT 1
- One extra sleep at the end of the retry loop in client.Do func
- hystrix POST with retry returns "http: ContentLength=... with Body length 0"
- feat: Support for fallbacks with context
- httpclient.Do forces closes connection
- How to integrate elasticsearch APM HOT 1
- data race in hystrix client HOT 1
- client.Do() panics when passed in invalid character for url
- Hystrix http client - Unit missing in configuration HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heimdall.