Giter VIP home page Giter VIP logo

Comments (8)

tylfin avatar tylfin commented on May 18, 2024 2

I opened a duplicate issue here: #274

Like I mentioned in that issue, it would be nice to either:

  • make this code generic and allow for configuration overrides OR
  • make this code extensible such that any third-party test suites need to be implemented separated e.g. testify, check.v1 and any future test suites

That way VS Code Go isn't discouraging developers from building new or different test suites packages due to lack of tooling.

If that sounds like overkill, I'm happy to extend the existing code to include check.v1

EDIT: I created a small fork that should solve this for folks running into issues YMMV https://github.com/tylfin/vscode-go-check

from vscode-go.

stamblerre avatar stamblerre commented on May 18, 2024 1

Similarly, there have been mentions on Slack of the code lenses not working with Testify-based tests.

from vscode-go.

stamblerre avatar stamblerre commented on May 18, 2024

I would be curious to know how many people want this change before we implement it. Please upvote #111 (comment) if you would use this feature.

from vscode-go.

ramya-rao-a avatar ramya-rao-a commented on May 18, 2024

Code lens support for testify based tests was added in microsoft/vscode-go#1707. So, if they are not working anymore, that is a regression.

from vscode-go.

tgturner avatar tgturner commented on May 18, 2024

I worked on an initial implementation. It was closed during the migration to the golang org. It's no longer in sync with master but might be a good starting off point for someone.

microsoft/vscode-go#3222

I'll try to get back to it and open the PR here because its a feature that I would really like to have, but if someone gets to it first I will not be offended.

from vscode-go.

hyangah avatar hyangah commented on May 18, 2024

@tgturner Thanks. Do you have any thought on my comment in #228 (comment)?

from vscode-go.

jcalabro avatar jcalabro commented on May 18, 2024

Hi all! I've opened a PR here for review (it simply extends the existing code to support check.v1, not any other test suites at this time). Thanks!

#1494

from vscode-go.

hyangah avatar hyangah commented on May 18, 2024

We hoped that we stop supporting third-party test libraries and move away from the GoDocumentSymbolProvider. The underlying tool for GoDocumentSymbolProvider is in maintenance mode and this go extension uses gopls document symbol providers. The third-party test code lens support is one of few remaining cases that are blocking deprecation.

Have you considered a separate, specialized extension for users who want to use all those test frameworks? If necessary, the extension can invoke the document symbol provider command and can create a code lens that invokes go extension's commands to run/debug tests too.

from vscode-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.